✨ add custom metrics

[mariuskimmina]

#213

Currently, this only adds one metrics mondoo_audit_config which shows the number of mondoAuditConfigs.

[mariuskimmina]

Set as draft MR so we can discuss which other metrics should be exposed

[czunker]

Hi @mariuskimmina ,

thanks for your PR.

The idea behind the issue was to get to the next capability level for the operator:

As you can see here, we are currently at level 3. We do not have any metrics we currently need. The amount of configs is a nice first indicator.

We appreciate your contribution and think this is the right direction going forward. It would be nice if you could add tests for the metrics.

[mariuskimmina]

thanks for the insight, I should be able to add tests sometime next week

[mariuskimmina]

Added a (very minimal) test for this

[czunker]

@mariuskimmina Thanks for adding the tests.

Strangely, now the linter step fails, which seems unrelated to your PR:

Error: /usr/bin/tar: ../../../go/pkg/mod/go.uber.org/multierr@v1.9.0/error.go: Cannot open: File exists

And a lot more like these. I need to look into this.

[czunker]

There are some issues, e.g., golangci/golangci-lint-action#244 and golangci/golangci-lint-action#135 which mention this problem. Perhaps the solution is just disabling some conflicting caching...

[czunker]

Strange, this job shows the same errors but still passes: https://github.com/mondoohq/mondoo-operator/actions/runs/5390664672/jobs/9833822310

[czunker]

The actual cause was burried somewhere in the logs:

2023-06-29T09:10:32.7051321Z ##[group]run golangci-lint
2023-06-29T09:10:32.7052505Z Running [/home/runner/golangci-lint-1.49.0-linux-amd64/golangci-lint run --out-format=github-actions --timeout=15m0s] in [] ...
2023-06-29T09:10:43.9061007Z ##[error]File is not `gofumpt`-ed (gofumpt)
2023-06-29T09:10:43.9062486Z ##[error]File is not `gofumpt`-ed (gofumpt)
2023-06-29T09:10:43.9064201Z ##[error]File is not `gofumpt`-ed (gofumpt)
2023-06-29T09:10:43.9065180Z ##[error]field `scheme` is unused (unused)
2023-06-29T09:10:43.9066164Z ##[error]const `controllerName` is unused (unused)
2023-06-29T09:10:43.9066594Z 
2023-06-29T09:10:43.9067059Z ##[error]issues found
2023-06-29T09:10:43.9067629Z Ran golangci-lint in 11201ms

@mariuskimmina Please have a look at the linter issues.

Note to myself: We still need to fix the error message to make it easier to find real problems.

[mariuskimmina]

Linter issues have been fixed @czunker

[mariuskimmina]

The failing test seem to be due to issues pulling images: trying and failing to pull image

[czunker]

Thanks for this contribution @mariuskimmina