Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix tar errors during golangci-lint execution #829

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jul 3, 2023

The errors polute the logs and make it hard to find real problems

For some background, see #812

The errors polute the logs and make it hard to find real problems

For some background, see #812

Signed-off-by: Christian Zunker <[email protected]>
@czunker
Copy link
Contributor Author

czunker commented Jul 3, 2023

This is the alternative to #828 Here, we lose the ability to choose the go version for the linting step.

Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer this approach

@czunker czunker merged commit 600e3ff into main Jul 6, 2023
@czunker czunker deleted the christian/fix_golinter_tar_errors_2 branch July 6, 2023 04:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants