KeepPrivateModule: Special case for moving bug reports to MCL #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urielsalis
approved these changes
Jul 15, 2023
violine1101
force-pushed
the
fix-mcl-private
branch
from
c217372 to
e6fd7d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Moving private bug reports to MCL would prompt Arisa to change their security level to an invalid one, making them inaccessible.
Approach
Changed the function for determining whether a bug report is public by checking if the security level is a private security level for any project, not just the current one.
Future work
This is more of a bandaid solution, the actual problem likely lies somewhere deeper: Moving bug reports might actually cause some weird things to happen in regards to the data that Arisa receives.
So, further monitoring is necessary and potentially a better solution should be found at some point in the future - if we do not end up merging the MCL security level with the regular one anyway.
Checklist
and
docsfolder