Also ignore changes to any private level in changelog

mojira · Jul 15, 2023 · c217372 · c217372
1 parent 5321356
commit c217372
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/kotlin/io/github/mojira/arisa/modules/KeepPrivateModule.kt b/src/main/kotlin/io/github/mojira/arisa/modules/KeepPrivateModule.kt
@@ -24,8 +24,8 @@ class KeepPrivateModule(
             setPrivate()
 
             val markedTime = comments.first(::isKeepPrivateTag).created
-            val securityChange = changeLog
-                .lastOrNull { isSecurityChangeToPublic(it, project.privateSecurity) }
+            val securityChange = changeLog.lastOrNull(::isSecurityChangeToPublic)
+
             val changedTime = securityChange?.created
             if (changedTime != null && changedTime.isAfter(markedTime)) {
                 if (
@@ -47,8 +47,8 @@ class KeepPrivateModule(
         comment.visibilityValue == "staff" &&
         (comment.body?.contains(keepPrivateTag!!) ?: false)
 
-    private fun isSecurityChangeToPublic(item: ChangeLogItem, privateLevel: String) =
-        item.field == "security" && item.changedFromString == privateLevel
+    private fun isSecurityChangeToPublic(item: ChangeLogItem) =
+        item.field == "security" && privateLevels.contains(item.changedFromString)
 
     private fun assertContainsKeepPrivateTag(comments: List<Comment>) = when {
         comments.any(::isKeepPrivateTag) -> Unit.right()