Fix proxy port configuration for non-default SERVER_PORT #555
+72
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
changed the base branch from
main
to
fweinberger/client-localhost
🎭 Playwright E2E Test Results✅ 12 passed Details12 tests across 1 suite 📊 View Detailed HTML Report (download artifacts) |
felixweinberger
force-pushed
the
fweinberger/fix-proxy-port-config
branch
4 times, most recently
from
0df3ce3 to
f7cbeab
Compare
9 tasks
cliffhall
requested changes
Jun 25, 2025
felixweinberger
force-pushed
the
fweinberger/fix-proxy-port-config
branch
from
6424232 to
554a922
Compare
- Update client to read MCP_PROXY_PORT from URL parameters - Update server to include port in displayed URL when non-default - Update start scripts to pass SERVER_PORT to client - Use DEFAULT_MCP_PROXY_LISTEN_PORT constant instead of magic numbers This fixes the issue where the client couldn't connect to the proxy when SERVER_PORT was set to a non-default value.
Address PR feedback by restructuring getClientUrl to always include MCP_PROXY_PORT parameter when using non-default port, regardless of auth status. Also improved code clarity by using params.size check.
felixweinberger
force-pushed
the
fweinberger/fix-proxy-port-config
branch
from
554a922 to
9e9419b
Compare
cliffhall
requested changes
Jun 26, 2025
There was a problem hiding this comment.
Non-default server port is working great, and if combined withDANGEROUSLY_OMIT_AUTH, also does the right thing.
There is one more wrinkle. If the user also has MCP_AUTO_OPEN_ENABLED set to false, then they are left with the situation of having no link that will actually open a working inspector. The MCP Inspector is up and running at http://localhost:6274 message isn't enough, it would also need to have ?MCP_PROXY_PORT=7777 appended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass proxy port via URL parameters when using non-default SERVER_PORT
Motivation and Context
Fixes the issue raised by @cliffhall in #529 where the client cannot connect to the proxy server when
SERVER_PORTis set to a non-default value.When the proxy server runs on a non-default port (not 6277), the client doesn't know about it and tries to connect to the default port. This creates a chicken-and-egg problem:
/configChanges:
getClientUrl()in start scripts to includeMCP_PROXY_PORTparameter when non-defaultMCP_PROXY_PORTfrom URL parameters and use it for proxy connectionDEFAULT_MCP_PROXY_LISTEN_PORTconstantHow Has This Been Tested?
npm run dev- worksSERVER_PORT=8888 npm run dev- works, client connects to port 8888npm run build && SERVER_PORT=9090 npm start- worksBreaking Changes
None.
Types of changes
Checklist
Additional context