Skip to content

Commit 6424232

Browse files
fix: ensure MCP_PROXY_PORT is included when auth is disabled
Address PR feedback by restructuring getClientUrl to always include MCP_PROXY_PORT parameter when using non-default port, regardless of auth status. Also improved code clarity by using params.size check.
1 parent f7cbeab commit 6424232

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

client/bin/start.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,20 @@ function getClientUrl(port, authDisabled, sessionToken, serverPort) {
1717
const host = process.env.HOST || "localhost";
1818
const baseUrl = `http://${host}:${port}`;
1919

20-
if (authDisabled) {
21-
return baseUrl;
22-
}
23-
2420
const params = new URLSearchParams();
25-
params.set("MCP_PROXY_AUTH_TOKEN", sessionToken);
2621

27-
// Add server port if it's not the default
22+
// Always add the proxy port if it's not the default
2823
if (serverPort && serverPort !== DEFAULT_MCP_PROXY_LISTEN_PORT) {
2924
params.set("MCP_PROXY_PORT", serverPort);
3025
}
3126

32-
return `${baseUrl}/?${params.toString()}`;
27+
// Only add auth token if auth is enabled
28+
if (!authDisabled) {
29+
params.set("MCP_PROXY_AUTH_TOKEN", sessionToken);
30+
}
31+
32+
// Only append query string if there are parameters
33+
return params.size > 0 ? `${baseUrl}/?${params.toString()}` : baseUrl;
3334
}
3435

3536
async function startDevServer(serverOptions) {

0 commit comments

Comments
 (0)