Skip to content

fix: Use translation key for aria-label close button (Issue #5) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
z5005z-hue wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Use translation key for aria-label close button (Issue #5) #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e57f2
fix: Use translation key for aria-label close button
Feb 21, 2026
4e5e1e9
fix: Add common.close to all locale files
Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/storefront/src/components/MenuItemModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export default function MenuItemModal({ itemId, onClose }: Props) {
<button
onClick={onClose}
className="absolute top-3 right-3 bg-white/80 hover:bg-white rounded-full p-1.5 transition-colors"
aria-label="Close"
aria-label={t("common.close")}
>
<svg className="w-5 h-5 text-gray-700" fill="none" viewBox="0 0 24 24" stroke="currentColor">
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M6 18L18 6M6 6l12 12" />
Expand Down
5 changes: 3 additions & 2 deletions packages/storefront/src/i18n/locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Suchen",
"noResults": "Keine Ergebnisse gefunden",
"viewAll": "Alle anzeigen",
"required": "Erforderlich"
"required": "Erforderlich",
"close": "Close"
},
"nav": {
"home": "Startseite",
Expand Down Expand Up @@ -225,4 +226,4 @@
"message": "Entschuldigung, die gesuchte Seite wurde nicht gefunden.",
"backHome": "Zurück zur Startseite"
}
}
}
3 changes: 2 additions & 1 deletion packages/storefront/src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Search",
"noResults": "No results found",
"viewAll": "View All",
"required": "Required"
"required": "Required",
"close": "Close"
},
"nav": {
"home": "Home",
Expand Down
5 changes: 3 additions & 2 deletions packages/storefront/src/i18n/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Buscar",
"noResults": "No se encontraron resultados",
"viewAll": "Ver todo",
"required": "Obligatorio"
"required": "Obligatorio",
"close": "Close"
},
"nav": {
"home": "Inicio",
Expand Down Expand Up @@ -225,4 +226,4 @@
"message": "Lo sentimos, no pudimos encontrar la página que buscas.",
"backHome": "Volver al Inicio"
}
}
}
5 changes: 3 additions & 2 deletions packages/storefront/src/i18n/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Rechercher",
"noResults": "Aucun résultat trouvé",
"viewAll": "Tout voir",
"required": "Obligatoire"
"required": "Obligatoire",
"close": "Close"
},
"nav": {
"home": "Accueil",
Expand Down Expand Up @@ -225,4 +226,4 @@
"message": "Désolé, nous n'avons pas trouvé la page que vous cherchez.",
"backHome": "Retour à l'Accueil"
}
}
}
5 changes: 3 additions & 2 deletions packages/storefront/src/i18n/locales/it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Cerca",
"noResults": "Nessun risultato trovato",
"viewAll": "Vedi Tutto",
"required": "Obbligatorio"
"required": "Obbligatorio",
"close": "Close"
},
"nav": {
"home": "Home",
Expand Down Expand Up @@ -225,4 +226,4 @@
"message": "Ci dispiace, non abbiamo trovato la pagina che stai cercando.",
"backHome": "Torna alla Home"
}
}
}
5 changes: 3 additions & 2 deletions packages/storefront/src/i18n/locales/pt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"search": "Pesquisar",
"noResults": "Nenhum resultado encontrado",
"viewAll": "Ver Tudo",
"required": "Obrigatório"
"required": "Obrigatório",
"close": "Close"
},
"nav": {
"home": "Início",
Expand Down Expand Up @@ -225,4 +226,4 @@
"message": "Desculpe, não conseguimos encontrar a página que você está procurando.",
"backHome": "Voltar ao Início"
}
}
}
Loading