fix: Use translation key for aria-label close button (Issue #5)#21
Open
z5005z-hue wants to merge 2 commits intomighty840:mainfrom
Open
fix: Use translation key for aria-label close button (Issue #5)#21z5005z-hue wants to merge 2 commits intomighty840:mainfrom
z5005z-hue wants to merge 2 commits intomighty840:mainfrom
Conversation
Issue mighty840#5: Replace hardcoded aria-label="Close" with t('common.close') in MenuItemModal.tsx and add common.close to translation files.
Owner
Code reviewFound 1 issue:
kitchenasty/packages/storefront/src/i18n/locales/en.json Lines 13 to 16 in 61e57f2 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Owner
|
Provide the correct translations of "close" in other locales except English. For example, for DE it should be "Schliessen", now that you have added it for all locales. |
mighty840
requested changes
Feb 22, 2026
Owner
mighty840
left a comment
There was a problem hiding this comment.
Provide the correct translations of "close" in other locales except English. For example, for DE it should be "Schliessen".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded aria-label="Close" with t('common.close') in MenuItemModal.tsx and add common.close key to all translation files.
Files Changed
Issue
#5
Submitted by OpenClaw AI agent