Skip to content

Conversation

@lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Oct 29, 2025

Pull Request Template – vscode-mssql

Description

This PR includes all the changes needed to edit data from within the MSSQL for VS Code extension.

Entry Points:

The Edit Data feature can be opened from a table node's context menu by clicking on "View Data (Preview)"

  1. Context Menu
    OpenFromContextMenu

  2. Double Click Object Explorer Table Node
    OpenFromDoubleClick

Editing Data

  1. Making changes and Saving Changes
    EditingData

  2. Reverting Changes
    RevertingRowAndSingleCell

  3. Delete Rows
    DeletingRows

Automatic DML Scripting

LiveDMLScripting

Save Button is disabled initially until a change is detected

Before changes:
image

After changes:
image

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 57.07% 58.01% ⚪ 0.00%
VSIX Size 4911 KB 5173 KB 🔴 262 KB ( 5% )
Webview Bundle Size 4032 KB 5212 KB 🔴 1180 KB ( 29% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 90.75975% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.00%. Comparing base (0cccaf5) to head (3bc7b22).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/tableExplorer/tableExplorerWebViewController.ts 90.35% 29 Missing and 1 partial ⚠️
src/controllers/mainController.ts 30.00% 14 Missing ⚠️
src/constants/locConstants.ts 97.14% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20376      +/-   ##
==========================================
+ Coverage   55.04%   56.00%   +0.95%     
==========================================
  Files         200      204       +4     
  Lines       17597    18083     +486     
  Branches     1156     1192      +36     
==========================================
+ Hits         9686    10127     +441     
- Misses       7911     7955      +44     
- Partials        0        1       +1     
Files with missing lines Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/controllers/reactWebviewPanelController.ts 90.69% <100.00%> (ø)
src/models/contracts/tableExplorer.ts 100.00% <100.00%> (ø)
src/objectExplorer/nodes/treeNodeInfo.ts 96.00% <100.00%> (+0.16%) ⬆️
src/services/tableExplorerService.ts 100.00% <100.00%> (ø)
src/sharedInterfaces/tableExplorer.ts 100.00% <100.00%> (ø)
src/sharedInterfaces/telemetry.ts 100.00% <100.00%> (ø)
src/constants/locConstants.ts 82.24% <97.14%> (+0.60%) ⬆️
src/controllers/mainController.ts 16.06% <30.00%> (+0.25%) ⬆️
...rc/tableExplorer/tableExplorerWebViewController.ts 90.35% <90.35%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@croblesm
Copy link
Contributor

Hi @lewis-sanchez,
The feature looks solid! I opened a couple of bugs related to the Show Script panel:

#20386 and #20385

cc @yoleichen, @jdesai-24

@aasimkhan30
Copy link
Contributor

Quick observations from the screenshots.

  1. I think the main pane has a lot of padding reducing screen real estate. Please remove padding so that we make better use of available space.

  2. Fix grid header header styling. Try to make them look more like result grid headers or table designer headers.

  3. When you open script pane, there is scrollbar in the main pane (hiding the bottom controls) even when all the content could easily fit in the visible area. Please make sure that bottom controls are sticky and are always visible at the bottom of the pane even when pane size changes.

  4. Let's have a different icon for edit data tabs so that it is easy to identify them. Currently they seem to look the same as result grid tabs.

  5. It will be nice if we can make cells more compact. I think we should reduce the column width and cell padding to fit more data in and reduce unnecessary scrolls.

@jdesai-24
Copy link

@lewis-sanchez can we keep the background color #234A22 and text #FFFFFFF for edited cell?

CC @croblesm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants