Skip to content

test: drop shard index from bot name #38636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 2 commits into from
Jan 6, 2026
+7 −2
Merged

test: drop shard index from bot name #38636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e0201
test: drop shard index from bot name
Skn0tt Dec 23, 2025
5800e02
Merge branch 'main' into test-drop-botname
Skn0tt Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/run-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ inputs:
bot-name:
description: 'Bot name'
required: true
shard-index:
description: 'Shard index (optional)'
required: false
default: '0'
shell:
description: 'Shell to use'
required: false
Expand Down Expand Up @@ -87,4 +91,4 @@ runs:
uses: ./.github/actions/upload-blob-report
with:
report_dir: blob-report
job_name: ${{ inputs.bot-name }}
job_name: ${{ inputs.bot-name }}-${{ inputs.shard-index }}
Copy link
Contributor

@dgozman dgozman Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can even use some random guid or timestamp here, since we do not really care about the artifact name.

Copy link
Member Author

@Skn0tt Skn0tt Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a random value / timestamp would require one more "script" step here since there's no randomness in github's templating language. i actually like shard-index, I had a couple of instances in the past where I wanted to download a single specific blob to do some experiments.

3 changes: 2 additions & 1 deletion .github/workflows/tests_primary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ jobs:
with:
node-version: ${{matrix.node-version}}
command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --shard-weights=58:42
bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shardIndex }}"
bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}"
Copy link
Member

@pavelfeldman pavelfeldman Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it break the merge via adding all the shard zips into the archive with the same name?

Copy link
Contributor

@dgozman dgozman Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report.zip includes shard index by default, so downloaded reports should be all distinct.

shard-index: ${{ matrix.shardIndex }}
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
Expand Down
Loading