Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hevc dcr generation #64

Merged
merged 2 commits into from
Jul 1, 2024
+5 −4
Merged

Fix hevc dcr generation #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97fffd
Fix hevc dcr generation
gBillal Jun 30, 2024
9809f62
add names to default fields
gBillal Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/membrane_h264_plugin/h265/decoder_configuration_record.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ defmodule Membrane.H265.DecoderConfigurationRecord do
progressive_source_flag::1, interlaced_source_flag::1, non_packed_constraint_flag::1,
frame_only_constraint_flag::1, reserved_zero_44bits::44, level_idc, 0b1111::4, 0::12,
0b111111::6, 0::2, 0b111111::6, chroma_format_idc::2, 0b11111::5,
bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::19,
num_temporal_layers + 1::2, temporal_id_nested::1, nalu_length_size - 1::2-integer>>
bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::18,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add some meaningful names to this:

Suggested change
bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::18,
avarage_framerate = 0 # not set
constant_framerate = 0 # not set
bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, avarage_framerate::16, constant_framerate::2,

num_temporal_layers + 1::3, temporal_id_nested::1, nalu_length_size - 1::2-integer>>

cond do
avc == :hvc1 ->
Expand Down
Loading