Fix hevc dcr generation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
reviewed
Jul 1, 2024
| @@ -80,8 +80,8 @@ defmodule Membrane.H265.DecoderConfigurationRecord do | |||
| progressive_source_flag::1, interlaced_source_flag::1, non_packed_constraint_flag::1, | |||
| frame_only_constraint_flag::1, reserved_zero_44bits::44, level_idc, 0b1111::4, 0::12, | |||
| 0b111111::6, 0::2, 0b111111::6, chroma_format_idc::2, 0b11111::5, | |||
| bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::19, | |||
| num_temporal_layers + 1::2, temporal_id_nested::1, nalu_length_size - 1::2-integer>> | |||
| bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::18, | |||
There was a problem hiding this comment.
I think we could add some meaningful names to this:
Suggested change
| bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, 0::18, | |
| avarage_framerate = 0 # not set | |
| constant_framerate = 0 # not set | |
| bit_depth_luma_minus8::3, 0b11111::5, bit_depth_chroma_minus8::3, avarage_framerate::16, constant_framerate::2, |
It's written here |
Oh, my bad, indeed it's there, I've looked at the wrong version of the spec |
varsill
approved these changes
Jul 1, 2024
|
@gBillal Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.