-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support for BrowserType.connect_over_cdp() (for chromium browser only) #37
base: main
Are you sure you want to change the base?
Conversation
# For some reason this still launches a chromium browser... I could not | ||
# figure out why. | ||
|
||
browser = Playwright.launch(:firefox) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coreyti any thoughts about how to better test this error case? I couldn't quite figure out why but it appears that no matter whether I call Playwright.launch()
with (ie :webkit
or :firefox
) I still get a chromium %Playwright.Browser{}
back.
Perhaps this is just something to note and move on from since technically this library only supports chromium at the moment.
Hey @oliverswitzer, I'm getting test suite timeouts when running Regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing... see comment above.
Seems that @coreyti and I narrowed the test issue down to It is the only test that calls |
After pairing a bit more through this with @coreyti, it became apparent that From poking around in the playwright-python and playwright-js client code, we discovered that each of the other libraries seem to have instances of The playwright server sends This duplication in the same catalog may be leading to some of the order-dependent test failures that we're seeing. It seems like our implementation of |
NOTES: * Fixes bug where Channel.list was not correctly filter on parent guid * Adds HTTPoison in test only TODOs: * Adds skipped test that makes sure connect_over_cdp raises if using a different browser than chromium. Currently not working because Playwright.launch(:firefox) still returns a chromium browser for some reason
5baae86
to
4983ed5
Compare
This PR adds support for playwright's BrowserType.connectOverCdp() function, which attaches Playwright to an existing browser instance using the Chrome DevTools Protocol.
BrowserType.connect_over_cdp
TODOs
headers
,logger
,slowMo
,timeout
)connect_over_cdp/3
can only be invoked when using chromium client