Implement BrowserType.connect_over_cdp - chromium only #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is heavily influenced by #37 by @oliverswitzer. Thank you for the inspiration and launching off point.
I'm proposing a slightly different contract that is consistent with the current approach used with
BrowserType.launch
Implements Browser.browser_type/1
Implements BrowserType.connect_over_cdp/3
Adds httpoison as test dependency in order to fetch WS url from chrome debugger tools endpoint
Refactors how launch options are provided to
BrowserType.launch
so they can be passed down and not require trying to override usingApplication.put_env
for tests. I believe that is the likely culprit causing the timeout issues in the previous pull request as once thats passed inargs: ["--remote-debugging-port=#{@remote_debug_port}"]
, everything else breaks.