Skip to content

fix(windows): close temp file before reopening for STT upload #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbailey merged 1 commit into from
Jan 14, 2026
Merged

fix(windows): close temp file before reopening for STT upload #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions voice_mode/tools/converse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,32 +475,46 @@ async def speech_to_text(
logger.info(f"STT audio saved to: {save_file_path} (format: {STT_SAVE_FORMAT})")

# Use compressed audio for upload (temporary file)
with tempfile.NamedTemporaryFile(suffix=f'.{file_extension}', delete=False) as tmp_file:
# Windows fix: close temp file before reopening (Issue #135)
tmp_file = tempfile.NamedTemporaryFile(suffix=f'.{file_extension}', delete=False)
tmp_path = tmp_file.name
try:
tmp_file.write(compressed_audio)
tmp_file.flush()
tmp_file.close() # Close before reopening on Windows

with open(tmp_file.name, 'rb') as audio_file:
with open(tmp_path, 'rb') as audio_file:
result = await simple_stt_failover(
audio_file=audio_file,
model="whisper-1"
)

finally:
# Clean up temp file (we keep the WAV)
os.unlink(tmp_file.name)
try:
os.unlink(tmp_path)
except OSError:
pass
else:
# Use temporary file that will be deleted
with tempfile.NamedTemporaryFile(suffix=f'.{file_extension}', delete=False) as tmp_file:
# Windows fix: close temp file before reopening (Issue #135)
tmp_file = tempfile.NamedTemporaryFile(suffix=f'.{file_extension}', delete=False)
tmp_path = tmp_file.name
try:
tmp_file.write(compressed_audio)
tmp_file.flush()
tmp_file.close() # Close before reopening on Windows

with open(tmp_file.name, 'rb') as audio_file:
with open(tmp_path, 'rb') as audio_file:
result = await simple_stt_failover(
audio_file=audio_file,
model="whisper-1"
)

finally:
# Clean up temp file
os.unlink(tmp_file.name)
try:
os.unlink(tmp_path)
except OSError:
pass

return result

Expand Down