fix(windows): close temp file before reopening for STT upload #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, temp files cannot be reopened while still held open by the original handle due to file locking. This fixes WinError 32: "The process cannot access the file because it is being used by another process" Closes mbailey#135 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
|
Thanks @Maheidem , will review soon. |
Owner
|
Many thanks @Maheidem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On Windows,
tempfile.NamedTemporaryFilekeeps the file handle open. When trying to reopen the file withopen(tmp_file.name, 'rb'), Windows throws:Solution
Close the temp file handle before reopening it for the STT upload.
Test plan
Closes #135
🤖 Generated with Claude Code