Skip to content

Commit

Permalink
Adjust codes which are parts of 'Step #6: Multisig Ownership'
Browse files Browse the repository at this point in the history
  • Loading branch information
masaun committed Feb 8, 2020
1 parent 668cb1e commit 17140ed
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
15 changes: 9 additions & 6 deletions contracts/NewBancorPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,15 @@ contract NewBancorPool2 is BnStorage, BnConstants, Managed {
// Step #5: Activation
// Step #6: Multisig Ownership
address _converterAddress; // @notice - This variable is for receiving return value of createConverter() below
uint32 _maxConversionFee = 1;
_converterAddress = bancorConverterFactory.createConverter(smartToken,
contractRegistry,
_maxConversionFee,
token,
reserveRatio);
// uint32 _maxConversionFee = 1;
// _converterAddress = bancorConverterFactory.createConverter(smartToken,
// contractRegistry,
// _maxConversionFee,
// token,
// reserveRatio);
bancorConverter.transferOwnership(msg.sender); // @dev - Reference from Managed.sol
bancorConverter.transferManagement(msg.sender); // @dev - Reference from Managed.sol
_converterAddress = address(bancorConverter);

// Step #7: Converters Registry Listing
bancorConverterRegistry.addConverter(IBancorConverter(_converterAddress));
Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"install": "node scripts/fix-modules.js",
"build": "node scripts/rebuild-all.js",
"test": "echo \"Error: no test specified\" && exit 1",
"deploy": "node scripts/deploy-one.js",
"verify": "node scripts/verify-all.js",
"flatten": "node scripts/flatten.js",
"deploy": "node scripts/bancor-protocol/deploy-one.js",
"verify": "node scripts/bancor-protocol/verify-all.js",
"flatten": "node scripts/bancor-protocol/flatten.js",
"test:truffle": "truffle test ./test/*",
"start-blank": "rm -rf client/src && cp -rf barebones/src client/",
"client": "cd client && npm run start",
Expand Down

0 comments on commit 17140ed

Please sign in to comment.