-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English to Nzema #120
base: master
Are you sure you want to change the base?
English to Nzema #120
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salomeyosei , This is very awesome, keep up the good work.
- Few point :
- can you please update the PR description or the readme to tell us more about the Nzema language? (Where it's spoken, how many people speaks it, for example)
- I saw that you add many starter notebooks, are they related to this language?
Those must be languages that i tried to train. The Nzema are an Akan people numbering about 328,700, of whom 262,000 live in southwestern Ghana and 66,700 live in the southeast of Côte d'Ivoire. In Ghana the Nzema area is divided into three electoral districts of Nzema East Municipal also referred to as Evalue Gwira, Ellembele District and Nzema West, which is also referred to as Jomoro District of Ghana. Their language is also known as Nzima (in Ghana) or Appolo (in the Ivory Coast). From Wikepedia. |
Read me file has been edited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @salomeyosei
Thank you very much for submitting a benchmark!
One thing from my side: the folder name should use the ISO language code.
The one for nzema is nzi
Would you change the folder name to en-nzi
?
@@ -0,0 +1,725 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the above, it looks like you haven't updated it to train for nzi
! This is training one for xh
i.e. isiXhosa
Is this the correct notebook?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i lost the main notebook...I don't know how but am still searching for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebook is wrong
Just confirmed. If i can't find it then i need to retrain
Looks good! Great work, @salomeyosei! 💯 As far as I can tell, the only thing that needs to get fixed are the additional notebooks not under the benchmarks directory. |
Salomey English to Nzema