Skip to content

taito/tc0080vco.cpp: fix HUD display for ainferno #10533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

taito/tc0080vco.cpp: fix HUD display for ainferno #10533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13d72d
taito/tc0080vco.cpp: transmask split for upper color bank, fixes ainf…
angelosa Nov 10, 2022
921e7c1
taito/tc0080vco.cpp: describe fix
angelosa Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/mame/taito/tc0080vco.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,17 @@ void tc0080vco_device::device_start()
m_tilemap[0] = &machine().tilemap().create(*this, tilemap_get_info_delegate(*this, FUNC(tc0080vco_device::get_bg0_tile_info)), TILEMAP_SCAN_ROWS, 16, 16, 64, 64);
m_tilemap[1] = &machine().tilemap().create(*this, tilemap_get_info_delegate(*this, FUNC(tc0080vco_device::get_bg1_tile_info)), TILEMAP_SCAN_ROWS, 16, 16, 64, 64);

m_tilemap[0]->set_transparent_pen(0);
m_tilemap[1]->set_transparent_pen(0);

// m_tilemap[0]->set_transparent_pen(0);
// m_tilemap[1]->set_transparent_pen(0);

// ainferno expects upper color bank to be transparent for hud and landing monitor to display properly.
// This is drawn with bit 15, is it expecting some kind of shadowing/blending? The PCB refs doesn't seem to show anything of the like.
// The only other place that sets upper color bank is tetristh, and doesn't seem to have any real effect.
// TODO: this arrangement may be controlled by m_scroll_ram[0] bits 7 and 6, which is either b11 or b00.
m_tilemap[0]->set_transmask(0, 0x0001, 0xfffe);
m_tilemap[0]->set_transmask(1, 0x8001, 0x7ffe);
m_tilemap[1]->set_transmask(0, 0x0001, 0xfffe);
m_tilemap[1]->set_transmask(1, 0x8001, 0x7ffe);
m_tilemap[0]->set_scrolldx(m_bg_xoffs, 512);
m_tilemap[1]->set_scrolldx(m_bg_xoffs, 512);
m_tilemap[0]->set_scrolldy(m_bg_yoffs, m_bg_flip_yoffs);
Expand Down Expand Up @@ -325,7 +333,7 @@ TILE_GET_INFO_MEMBER(tc0080vco_device::get_bg0_tile_info)
color = m_bg0_ram_1[tile_index] & 0x001f;
tile = m_bg0_ram_0[tile_index] & 0x7fff;

tileinfo.category = 0;
tileinfo.group = color >> 4;

tileinfo.set(0,
tile,
Expand All @@ -340,7 +348,7 @@ TILE_GET_INFO_MEMBER(tc0080vco_device::get_bg1_tile_info)
color = m_bg1_ram_1[tile_index] & 0x001f;
tile = m_bg1_ram_0[tile_index] & 0x7fff;

tileinfo.category = 0;
tileinfo.group = color >> 4;

tileinfo.set(0,
tile,
Expand Down