Skip to content

Conversation

@siemen11
Copy link
Contributor

Add the version of the crypto library to the pentest framework's readout for the crypto related init functions.

@siemen11 siemen11 requested a review from a team as a code owner October 31, 2025 10:49
@siemen11 siemen11 requested review from johannheyszl, nasahlpa and timothytrippel and removed request for a team and timothytrippel October 31, 2025 10:49
@siemen11 siemen11 marked this pull request as draft October 31, 2025 10:56
@siemen11
Copy link
Contributor Author

This is the integration of #28550 in the pentest framework

@siemen11 siemen11 force-pushed the pentest_cryptolib_version branch from e0bb188 to e460335 Compare October 31, 2025 11:46
@siemen11 siemen11 added the CI:Rerun Rerun failed CI jobs label Oct 31, 2025
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Oct 31, 2025
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Siemen.

Would it be possible to split this PR in a refactor and a CL versioning commit?

@siemen11 siemen11 force-pushed the pentest_cryptolib_version branch 3 times, most recently from 5ed2f5f to cbc9a58 Compare October 31, 2025 15:18
@siemen11
Copy link
Contributor Author

siemen11 commented Oct 31, 2025

Thanks Siemen.

Would it be possible to split this PR in a refactor and a CL versioning commit?

Thanks Pascal, this is split up now

Source format the python files in host penetrationtests.

Signed-off-by: Siemen Dhooghe <[email protected]>
@siemen11 siemen11 force-pushed the pentest_cryptolib_version branch from cbc9a58 to ea7784c Compare October 31, 2025 15:27
@siemen11 siemen11 force-pushed the pentest_cryptolib_version branch from ea7784c to 7c8c24f Compare November 3, 2025 09:53
@siemen11 siemen11 marked this pull request as ready for review November 3, 2025 09:54
@siemen11
Copy link
Contributor Author

siemen11 commented Nov 3, 2025

Example version output is:

CRYPTO version 000007f4, released false, hash 5d6115a

Add the version of the crypto library to the pentest framework's readout
for the crypto related init functions.

In order to have the latest git hash be printed as the version, all
commands or tests should be run with the --stamp flag in the Bazel
command.

Signed-off-by: Siemen Dhooghe <[email protected]>
@siemen11 siemen11 force-pushed the pentest_cryptolib_version branch from 7c8c24f to 4bf2713 Compare November 3, 2025 10:17
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Siemen, the output looks correct to me.

@nasahlpa nasahlpa merged commit d4df30f into lowRISC:earlgrey_1.0.0 Nov 3, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants