Skip to content

Conversation

@michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jan 13, 2026

Description

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jan 13, 2026
@michaelmckinsey1 michaelmckinsey1 changed the title Bump spack-packages Bump spack-packages version Jan 13, 2026
@michaelmckinsey1
Copy link
Collaborator Author

Only expected failures are [matrix, llnl-matrix, lammps, +cuda] and [matrix, llnl-matrix, sparta-snl, +cuda~gpu-aware-mpi]. Will need to look into other failures

@github-actions github-actions bot added the system New or modified system config label Jan 14, 2026
depends_on("kokkos+wrapper", when="+cuda")

# Kokkos 5 not building
depends_on("kokkos@:4", when="@:20250722 +kokkos")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Is this expected to be necessary?

depends_on("kokkos+wrapper+cuda cxxstd=17", when="+cuda")

# Kokkos 5 not building
depends_on("kokkos@:4", when="+kokkos")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Is this expected to be necessary?

@michaelmckinsey1 michaelmckinsey1 requested review from rfhaque and scheibelp and removed request for rfhaque January 14, 2026 17:01
@michaelmckinsey1 michaelmckinsey1 added the ready for review Ready for review label Jan 14, 2026
@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Jan 14, 2026
4 tasks
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.08%. Comparing base (8f8a496) to head (9d99988).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1186      +/-   ##
===========================================
+ Coverage    62.99%   63.08%   +0.08%     
===========================================
  Files           45       45              
  Lines         3432     3432              
  Branches       264      264              
===========================================
+ Hits          2162     2165       +3     
+ Misses        1261     1258       -3     
  Partials         9        9              
Files with missing lines Coverage Δ
systems/llnl-elcapitan/system.py 37.01% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pearce8 pearce8 merged commit c84a9e9 into develop Jan 15, 2026
48 checks passed
@pearce8 pearce8 deleted the michaelmckinsey1-patch-1 branch January 15, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application ready for review Ready for review system New or modified system config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants