Several metrics changes #5123
Open
Several metrics changes #5123
+256
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2025
Contributor
Author
This was referenced Dec 11, 2025
ndr-ds
force-pushed
the
11-28-several_metrics_changes
branch
from
58b94ab to
8b41b5a
Compare
This was referenced Dec 15, 2025
Draft
ndr-ds
force-pushed
the
11-28-several_metrics_changes
branch
from
8b41b5a to
bb38573
Compare
This was referenced Jan 7, 2026
ndr-ds
changed the base branch from
12-01-rocksdb_config_tuning
to
graphite-base/5123
ndr-ds
force-pushed
the
11-28-several_metrics_changes
branch
from
bb38573 to
26e0c2b
Compare
ndr-ds
force-pushed
the
graphite-base/5123
branch
from
8680174 to
241959f
Compare
ndr-ds
changed the base branch from
graphite-base/5123
to
11-28-make_notification_and_cross_chain_queue_sizes_grow_with_network_size
ndr-ds
force-pushed
the
11-28-several_metrics_changes
branch
from
26e0c2b to
c0eced0
Compare
ndr-ds
force-pushed
the
11-28-several_metrics_changes
branch
from
c0eced0 to
73b4c94
Compare
deuszx
reviewed
Jan 8, 2026
| // Put back the sender in the cache for next time. | ||
| chain_workers.insert(chain_id, sender); | ||
| #[cfg(with_metrics)] | ||
| metrics::CHAIN_WORKER_ENDPOINTS_CACHED.set(chain_workers.len() as i64); |
Contributor
There was a problem hiding this comment.
Will this decrement properly as chain workers are removed from the cache? i.e. is this the only place where workers are being evicted? Or can they be also dropped elsewhere (and we'd get outdated values in metrics).
afck
reviewed
Jan 8, 2026
| ) | ||
| }); | ||
|
|
||
| /// Number of cached chain worker channel endpoints in the BTreeMap. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Number of cached chain worker channel endpoints in the BTreeMap. | |
| /// Number of cached chain worker channel endpoints in the `BTreeMap`. |
(or: "in the map"?)
| ) -> Result<(ChainInfoResponse, NetworkActions), WorkerError> { | ||
| trace!("{} <-- {:?}", self.nickname, certificate); | ||
| #[cfg(with_metrics)] | ||
| let metrics_data = ( |
Contributor
There was a problem hiding this comment.
Let's introduce a struct MetricsData for that, and make this line just:
let metrics_data = MetricsData::new(&certificate);| #[cfg(with_metrics)] | ||
| { | ||
| if matches!(_outcome, BlockOutcome::Processed) { | ||
| let ( |
Contributor
There was a problem hiding this comment.
…then we could just call something like metrics_data.record() here. (Or log? gather? update?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Several metrics improvements were needed:
Proposal
chain_worker_request_queue_wait_timehistogram metricTest Plan
Release Plan