GDK CMake support (Xbox Series X only for now) #13185
Draft
+140
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcnor
commented
Jun 6, 2025
| @@ -7,6 +7,11 @@ endif() | |||
| # See docs/release_checklist.md | |||
| project(SDL3 LANGUAGES C VERSION "3.3.0") | |||
|
|
|||
| if (GDK_GAMING_XBOX) | |||
| # FIXME: Setting the standard of individual files doesn't seem to work properly | |||
There was a problem hiding this comment.
After I left this comment I realized that the standard for individual files cannot be changed, which is a shame. Hence the only solution is either leaving this or creating a separate target with the individual files that need to be set to C++17, but that makes it complicated as they're all mixed with the Windows support...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support to build Xbox Series X using CMake. It's a bit of a mess, hence marking it as a draft. This can obviously be updated so support is added to Xbox One & Desktop too, but I haven't had the time to test those yet.
Because there is no "official" CMake support, I've used
GDK_GAMING_XBOXand friends to detect support for it. I was convinced I got those from the official CMake examples here https://github.com/microsoft/Xbox-GDK-Samples/blob/main/Samples/Tools/CMakeExample/CMake/CMakeGDKScarlett.cmake but taking a look at them now I can't find that definition (my defs are many years old at this point, maybe this simply changed), so this should probably be changed, or some kind of convention added to the docs for CMake support.Really open to suggestions before moving to "normal" PR status.