Skip to content

chore(deps): bump hickory-resolver and hickory-proto #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Apr 1, 2025

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Cargo.toml Outdated
Comment on lines 129 to 130
hickory-proto = { version = "0.25", default-features = false }
hickory-resolver = { version = "0.25", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to also specify the patch version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this! overall looks good, left a comment

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Apr 3, 2025

@jxs since async-std-resolver has not published a v0.25 stable version, thus it's incompatible with [email protected] I have to revert to v0.24 to make it compile. We could do the upgrade again once either async-std is removed from rust-libp2p or async-std-resolver publishes a v0.25 stable version.

@hanabi1224 hanabi1224 marked this pull request as ready for review April 3, 2025 11:18
@elenaf9
Copy link
Member

elenaf9 commented Apr 5, 2025

I would prefer if we not downgrade the version back to v0.24.
Is the current dependency to the unstable 0.25.0-alpha an issue for you @hanabi1224? Otherwise I'd suggest we wait for the async-std-resolver stable release.

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Apr 7, 2025

@elenaf9 Unfortunately async-std-resolver has been deprecated and v0.25 will not likely be released. If downgrade is not desired, this could only be landed after async-std code is removed from rust-libp2p

https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0

Support for the async-std runtime has been removed following the deprecation of the async-std crate by upstream (see their README). The async-std-resolver crate will no longer be updated.

@elenaf9
Copy link
Member

elenaf9 commented Apr 7, 2025

@elenaf9 Unfortunately async-std-resolver has been deprecated and v0.25 will not likely be released. If downgrade is not desired, this could only be landed after asyn-std code is removed from rust-libp2p

https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0

Support for the async-std runtime has been removed following the deprecation of the async-std crate by upstream (see their README). The async-std-resolver crate will no longer be updated.

We agreed now to remove async_std support, so once that's done we can move forward with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants