-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(deps): bump hickory-resolver and hickory-proto #5968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cargo.toml
Outdated
hickory-proto = { version = "0.25", default-features = false } | ||
hickory-resolver = { version = "0.25", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to also specify the patch version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this! overall looks good, left a comment
@jxs since |
I would prefer if we not downgrade the version back to |
@elenaf9 Unfortunately https://github.com/hickory-dns/hickory-dns/releases/tag/v0.25.0
|
We agreed now to remove |
Description
Notes & open questions
Change checklist