Skip to content

chore: deprecate async_std support in DNS crate #5959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

gitToki
Copy link

@gitToki gitToki commented Mar 26, 2025

ref #5935

crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitToki

Comment on lines 699 to 700
#[cfg(feature = "tokio")]
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the additional feature gate here anymore.

@gitToki
Copy link
Author

gitToki commented Apr 17, 2025

@elenaf9 sorry for these

@grantkee
Copy link

grantkee commented May 5, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Edit: #5899 was merged just now, so you probably also need to merge master again and double check the tests that were added in that PR.

@@ -12,7 +12,6 @@ categories = ["network-programming", "asynchronous"]

[features]
full = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing async-std from the top-level libp2p crate should be done in a separate PR after it was removed from all other sub-crates.

@grantkee
Copy link

grantkee commented May 5, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

Copy link
Contributor

mergify bot commented May 5, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@gitToki
Copy link
Author

gitToki commented May 7, 2025

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

Yes I am sorry for the delay

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing, can you please take a look @gitToki ?

Copy link
Contributor

mergify bot commented May 18, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

@gitToki
Copy link
Author

gitToki commented May 18, 2025

CI is still failing, can you please take a look @gitToki ?

The test should now work @jxs there are just 2 test that I had to change : identify_external_addr_report and update_address_on_connect in memory_store.rs because of different timing behavior in Tokio's task scheduler and network address format differences.

Copy link
Contributor

mergify bot commented May 21, 2025

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants