-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: deprecate async_std support in DNS crate #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gitToki
#[cfg(feature = "tokio")] | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the additional feature gate here anymore.
@elenaf9 sorry for these |
Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the
hickory-proto
crate I need to address ASAP. I'm blocked on upgrading myreth
dependency until this is updated inrust-libp2p
. Is there something I can do to help get this updated?
CI is still failing (see below comment), and rustfmt is needed, rest LGTM.
Edit: #5899 was merged just now, so you probably also need to merge master again and double check the tests that were added in that PR.
libp2p/Cargo.toml
Outdated
@@ -12,7 +12,6 @@ categories = ["network-programming", "asynchronous"] | |||
|
|||
[features] | |||
full = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing async-std
from the top-level libp2p
crate should be done in a separate PR after it was removed from all other sub-crates.
Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help? |
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
Yes I am sorry for the delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still failing, can you please take a look @gitToki ?
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
The test should now work @jxs there are just 2 test that I had to change : |
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
ref #5935
crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.