-
Notifications
You must be signed in to change notification settings - Fork 189
Add flood publishing in py-libp2p #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add flood publishing in py-libp2p #939
Conversation
@seetadev The FloodSub publishing functionality is already working correctly in py-libp2p. The examples and documentation I created demonstrate this functionality and provide guidance for users who want to use FloodSub. |
@SuchitraSwain : HI Suchitra, wish if you could resolve the merge conflicts. Re-ran the CI/Cd pipeline. Waiting for the test results. |
@seetadev please Re-ran the CI/Cd pipeline. |
Can you add me to this branch? |
@bomanaps and @SuchitraSwain : Lets resolve the CI/CD issues that are failing. For the kad-dht issue, we investigated it and documented it at #949 . @yashksaini-coder , @sumanjeet0012 and @acul71 are fixing it. We will soon have the kad-dht test issue resolved. |
@bomanaps and @SuchitraSwain : Please resolve the other CI/Cd issues in the meantime. |
@bomanaps and @SuchitraSwain : Please resolve the other CI/Cd issues in the meantime. Kindly take help from @acul71, @Winter-Soren and @sumanjeet0012. They are working on gossipsub/floodsub stack. |
@seetadev @SuchitraSwain I'm working on resolving the CI/CD failures |
@seetadev could you please run CI/CD |
I can see that this tests are hanging (I did set a manual timeout) FAILED tests/interop/go_libp2p/test_floodsub_interop.py::test_floodsub_basic_functionality - Failed: Timeout (>80.0s) from pytest-timeout.
FAILED tests/interop/js_libp2p/test_floodsub_interop.py::test_floodsub_js_compatibility - Failed: Timeout (>80.0s) from pytest-timeout. |
@seetadev could you re-run the CI/CD please |
I’ve reviewed the PR and appreciate the comprehensive approach you’ve taken with the documentation, examples, and tests. The The examples ( The addition of the Here are a few points for further improvement:
Overall, this is a valuable addition to py-libp2p that will enhance the flexibility and usability. With the interoperability and example issues addressed, I believe this PR would be ready for merging. |
…iscussion template
@seetadev @Winter-Soren I have addressed all the comments., please review the PR again |
@SuchitraSwain A quick review that I would like to add here, Please run the make command There are still some issue to be resolved in this PR.
|
What was wrong?
Issue #
How was it fixed?
Summary of approach.
🔍 Technical Details
The FloodSub publishing flow works as follows:
To-Do
Cute Animal Picture