WFE: Refuse to finalize orders with unrecognized profiles #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
wfe-finalize-unknown-profile
branch
from
1bf9276 to
af546fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current profiles draft (https://datatracker.ietf.org/doc/draft-aaron-acme-profiles/00/) says:
Add types and helper functions representing this new error type to the berrors, probs, and web packages. Update the WFE code which rejects new-order requests with unrecognized profiles to use these new types, and add similar code to the WFE's finalize path. Update the unit and integration tests to reflect the fact that we now configure at least one profile in both Staging and Prod (tracked in IN-10574).