Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA: Use Validation Profiles to determine order/authz lifetimes #7989

Draft
wants to merge 1 commit into
base: wfe-finalize-unknown-profile
Choose a base branch
from

Conversation

aarongable
Copy link
Contributor

Add three new fields to the ra.ValidationProfile structure, representing the profile's pending authorization lifetime (used to assign an expiration when a new authz is created), valid authorization lifetime (used to assign an expiration when an authz is successfully validated), and order lifetime (used to assign an expiration when a new order is created). Remove the prior top-level fields which controlled these values across all orders. Add a "defaultProfileName" field to the RA as well, to facilitate looking up a default set of lifetimes when the order doesn't specify a profile.

Modify the RA's config struct in a corresponding way: add three new fields to the ValidationProfiles structure, and deprecate the three old top-level fields. Also upgrade the ra.NewValidationProfile constructor to handle these new fields, including doing validation on their values.

TODO: use ra.defaultProfileName to ensure a profile is always populated in issuance requests to the CA, and deprecate ca.defaultProfileName.

TODO: file a ticket to track the corresponding staging/prod config changes

Fixes #7605


Warning

Do not merge until #7988 has been merged and the above TODOs have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant