Multizone AHU controller: Removed measured input, fixed singular issues #3531

JayHuLBL · 2023-09-20T21:03:44Z

This closes #3526.

removed the measured damper position inputs
added 2-position relief damper boolean output
added electric heating coil option
fixed singular issues

AntoineGautier

We are getting very close!
I used this script to test all valid combinations of the controller parameters (this is based on the developments from #3528).
https://github.com/AntoineGautier/modelica-buildings/blob/tmp/issue3526_connectors/Buildings/Resources/Scripts/travis/templates/VAVMultiZoneController.py
It turns out that only 11 % of the tested combinations fail to simulate (with a high probability of a recurring pattern that could explain most of them). I am sending the log file to you by email so that you can inspect and debug the faulty ones.

In addition, I have the following comments.

Inside Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.SetPoints.PlantRequests the input uCooCoiSet is not conditional. The block is still incompatible with the following options.

No cooling coil
DX coil

Could we introduce a parameter to specify the type of cooling coil, and adapt the block in a similar manner as with have_hotWatCoi?
Also, since we want to cover 3 options for the heating coil (none, HW, electric) and for the cooling coil (none, CHW, DX) I would introduce enumerations to describe these options, rather than increase the number of Boolean parameters, such as have_hotWatCoi and have_eleHeaCoi. Note also that the implementation currently does not avoid have_hotWatCoi=true and have_eleHeaCoi=true, which an enumeration would avoid.

…n name

JayHuLBL · 2023-09-22T21:13:00Z

@AntoineGautier I added the new enumeration Buildings.Controls.OBC.ASHRAE.G36.Types.Coil that lists coil types. However, it has less items than the one in Template folder Buildings.Templates.Components.Types.Coil.

The new enumeration has been applied in MultiZone and single zone VAV controller, and also the terminal unit controllers. Due to the change, I believe the template models also need to update.

AntoineGautier · 2023-09-22T21:39:56Z

@JayHuLBL Noted. I'll refactor the templates via a commit to the branch issue3526_connectors early next week.

AntoineGautier · 2023-09-25T08:08:47Z

Buildings/Controls/OBC/ASHRAE/G36/AHUs/MultiZone/VAV/Controller.mo

+  parameter Buildings.Controls.OBC.ASHRAE.G36.Types.Coil cooCoi=Buildings.Controls.OBC.ASHRAE.G36.Types.Coil.WaterBasedCooling
+    "Cooling coil type"
    annotation (__cdl(ValueInReference=false),
                Dialog(group="System and building parameters"));
-  parameter Boolean have_eleHeaCoi=false
-    "True: the AHU has electric heating coil"
+  parameter Buildings.Controls.OBC.ASHRAE.G36.Types.Coil heaCoi=Buildings.Controls.OBC.ASHRAE.G36.Types.Coil.WaterBasedHeating
+    "Heating coil type"
    annotation (__cdl(ValueInReference=false),
                Dialog(group="System and building parameters"));


@JayHuLBL I think 2 distinct enumerations should be introduced: one for heating coils, another one for cooling coils.
The current implementation does not prevent from selecting cooCoi=Buildings.Controls.OBC.ASHRAE.G36.Types.Coil.ElectricHeating for example (the simulation of Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Validation.Controller actually succeeds with this class modification).
Let me know if this is possible. (I'll wait before refactoring the VAV template.)

JayHuLBL · 2023-09-25T17:01:35Z

@AntoineGautier I was thinking about having two distinct enumeration, but realized that in Template folder, it also uses one enumeration. Will the same issue exist for the template models?
However, it would be relatively easy to make the change to have two enumuerations. Please let me know your thought about the one in Template folder.

AntoineGautier · 2023-09-25T17:13:25Z

The use of the enumeration differs in the Templates package. The enumeration itself is not exposed to the user, but only used "in the background", as a means of type introspection, for example:

within Buildings.Templates.Components.Coils;
model ElectricHeating "Modulating electric heating coil"
  extends Buildings.Templates.Components.Interfaces.PartialCoil(
    final typ=Buildings.Templates.Components.Types.Coil.ElectricHeating,

At the top-level, we use replaceable components with an explicit choices annotation, for example:

replaceable Buildings.Templates.Components.Coils.WaterBasedHeating coiHeaPre(...)
    constrainedby Buildings.Templates.Components.Interfaces.PartialCoil(...)
    "Heating coil in preheat position"
    annotation (
    choices(
      choice(
        redeclare replaceable Buildings.Templates.Components.Coils.None coiHeaPre
        "No coil"),
      choice(
        redeclare replaceable Buildings.Templates.Components.Coils.WaterBasedHeating coiHeaPre(
          redeclare final package MediumHeaWat=MediumHeaWat,
          redeclare final Buildings.Templates.Components.Valves.TwoWayModulating val)
        "Hot water coil with two-way valve"),
      choice(
        redeclare replaceable Buildings.Templates.Components.Coils.ElectricHeating coiHeaPre
        "Modulating electric heating coil")),

Having enumerations that differ between the packages Controls and Templates is not an issue. (Of course, if we can use the same, this is better, but this is not a requirement.)

JayHuLBL · 2023-09-25T18:38:44Z

@AntoineGautier I just changed the one enumeration to two enumerations for heating and cooling coil.

AntoineGautier · 2023-09-26T10:13:12Z

I updated the templates in my last commit 052bdb3.

However, the model Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Validation.Controller fails to compile with the following class modification.

conAHU(heaCoi=Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.Electric)

The model Buildings.Controls.OBC.ASHRAE.G36.TerminalUnits.Reheat.Controller enables selecting heaCoi=Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.None. This should not be permitted as then it is a cooling-only box that is modeled with Buildings.Controls.OBC.ASHRAE.G36.TerminalUnits.CoolingOnly.
If choices annotations are allowed in CDL, you can restrict the choices exposed in the parameter dialog by adding such annotation to the declaration of parameter Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil heaCoi: see example with KindOfController at https://specification.modelica.org/maint/3.5/inheritance-modification-and-redeclaration.html#annotation-choices-for-suggested-redeclarations-and-modifications.
But since this is only a UI feature, an assert statement guarding against heaCoi==Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoil.None is also needed.

JayHuLBL · 2023-09-27T23:23:10Z

@AntoineGautier The compiling error of the Buildings.Controls.OBC.ASHRAE.G36.AHUs.MultiZone.VAV.Validation.Controller has been addressed.
For the heating coil options in reheat box, I reintroduce the parameter have_hotWatCoi to avoid the choose of None coil. However, this is a unique parameter for reheat coil only. Please let me know if it is a good strategy to do so.

AntoineGautier · 2023-09-28T14:23:14Z

That makes sense. I updated the VAV box template with the parameter have_hotWatCoi in commit 9c1952d.

…ssue3526_connectors

AntoineGautier · 2023-10-07T12:00:01Z

@JayHuLBL This is ready to merge I believe.

JayHuLBL · 2023-10-09T23:30:04Z

@mwetter Please let us know if it is ready to merge.

JayHuLBL · 2023-10-16T13:59:25Z

@mwetter The tests have passed and it is ready for your review.

JayHuLBL added 8 commits September 18, 2023 11:28

removed coil valve position input connectors

3317f8a

added revision note and conversion script

686c759

added electric heating coil option

64dd700

added 2-position relief damper position output

bec3e66

fixed singular error due to the choose of hardwired freezestat

1493118

corrected validation model

3e8cc69

corrected condition for enabling returning air temperature input

4ed0089

added release note

e5f098a

JayHuLBL requested a review from AntoineGautier September 20, 2023 21:03

JayHuLBL self-assigned this Sep 20, 2023

JayHuLBL added 2 commits September 21, 2023 10:51

improved validation model

a6025c7

fixed error due to the remove of the input connector

f173e7d

AntoineGautier requested changes Sep 22, 2023

View reviewed changes

AntoineGautier mentioned this pull request Sep 22, 2023

Templates • Testing automation #3528

Merged

4 tasks

JayHuLBL added 4 commits September 22, 2023 10:22

changed pressure control enumeration name

1ea7e78

added coil type enumeration, changed pressure control type enumeratio…

908490a

…n name

added coil enumeration and removed the have_hotWatCoi or have_eleHeaCoi

37f9cf9

added conditional cooling coil types [ci skip]

8997416

AntoineGautier reviewed Sep 25, 2023

View reviewed changes

JayHuLBL added 2 commits September 25, 2023 10:41

merged master

4dcdea0

Differentiated heating and cooling coil enumeration

5bdd224

AntoineGautier and others added 3 commits September 26, 2023 12:16

Refactor templates for new enumerations from OBC [ci skip]

052bdb3

merged master

c4f11a3

corrected conditions enabled/disable blocks in freeze protection

51d77b3

added boolean parameter to constrain heating coil options

f332a35

Revert to Boolean parameter for heating coil

9c1952d

Merge branch 'master' of github.com:lbl-srg/modelica-buildings into i…

1455ea1

…ssue3526_connectors

AntoineGautier approved these changes Oct 7, 2023

View reviewed changes

mwetter merged commit dcf68dd into master Oct 24, 2023

mwetter deleted the issue3526_connectors branch October 24, 2023 17:42

AntoineGautier mentioned this pull request Nov 5, 2023

Incompatibility with MBL master lbl-srg/ctrl-flow-dev#365

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multizone AHU controller: Removed measured input, fixed singular issues #3531

Multizone AHU controller: Removed measured input, fixed singular issues #3531

JayHuLBL commented Sep 20, 2023

AntoineGautier left a comment •

edited

Loading

JayHuLBL commented Sep 22, 2023

AntoineGautier commented Sep 22, 2023

AntoineGautier Sep 25, 2023

JayHuLBL commented Sep 25, 2023

AntoineGautier commented Sep 25, 2023

JayHuLBL commented Sep 25, 2023

AntoineGautier commented Sep 26, 2023 •

edited

Loading

JayHuLBL commented Sep 27, 2023

AntoineGautier commented Sep 28, 2023

AntoineGautier commented Oct 7, 2023

JayHuLBL commented Oct 9, 2023

JayHuLBL commented Oct 16, 2023

Multizone AHU controller: Removed measured input, fixed singular issues #3531

Multizone AHU controller: Removed measured input, fixed singular issues #3531

Conversation

JayHuLBL commented Sep 20, 2023

AntoineGautier left a comment • edited Loading

Choose a reason for hiding this comment

JayHuLBL commented Sep 22, 2023

AntoineGautier commented Sep 22, 2023

AntoineGautier Sep 25, 2023

Choose a reason for hiding this comment

JayHuLBL commented Sep 25, 2023

AntoineGautier commented Sep 25, 2023

JayHuLBL commented Sep 25, 2023

AntoineGautier commented Sep 26, 2023 • edited Loading

JayHuLBL commented Sep 27, 2023

AntoineGautier commented Sep 28, 2023

AntoineGautier commented Oct 7, 2023

JayHuLBL commented Oct 9, 2023

JayHuLBL commented Oct 16, 2023

AntoineGautier left a comment •

edited

Loading

AntoineGautier commented Sep 26, 2023 •

edited

Loading