Templates • Testing automation #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean validation models for VAV box.
…ssue3520_templateTesting
AntoineGautier
force-pushed
the
issue3520_templateTesting
branch
2 times, most recently
from
e6dbfdb to
6ea5304
Compare
AntoineGautier
force-pushed
the
issue3520_templateTesting
branch
from
6ea5304 to
5984d6a
Compare
docker pull was not run before, hence simulations failing.
AntoineGautier
force-pushed
the
issue3520_templateTesting
branch
from
5f17768 to
fafb891
Compare
4 tasks
…ssue3520_templateTesting
AntoineGautier
changed the title
…ssue3520_templateTesting
6 tasks
mwetter
reviewed
Feb 1, 2024
mwetter
reviewed
Feb 1, 2024
There was a problem hiding this comment.
@AntoineGautier : the setup for the testing looks good to me. I only added one inline comment as I am not sure what the best way is for configuring solver options. (The conf.yml file is read by then the solver is hard coded.)
|
@mwetter This is ready to merge in my opinion. Crossing fingers that this will not destroy MBL CI testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3520: please read the comments about time out and checksum verification on the issue page.
The high number of changed files is due to the fact that only one validation model is kept for each system type. All supported configurations are then generated with Python scripts by modifying this unique validation model.
The main developments from this PR are within
Buildings/Resources/Scripts/travis/templates.This PR also includes some fixes needed to support some configurations that had not been validated before and that the new test workflow exposed as faulty. Most of these are related to #3526. The rest are due to missing parameters for the number of return and relief fans within the configuration record.
TODO before merging: