feat: add InternalClientProvider for Toolbar flags and analytics #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranjal-jately-ld
force-pushed
the
internal-toolbar-client
branch
from
8563cfb to
e506011
Compare
- Introduced InternalClientProvider to manage the internal LaunchDarkly client for toolbar features and analytics.
- Added support for loading environment variables with the TOOLBAR_ prefix in the toolbar configuration files. - Introduced a new vite-env.d.ts file to define environment variable types for better TypeScript support.
…ternal client - Added support for TOOLBAR_INTERNAL_BASE_URL, TOOLBAR_INTERNAL_STREAM_URL, and TOOLBAR_INTERNAL_EVENTS_URL in the toolbar configuration.
pranjal-jately-ld
force-pushed
the
internal-toolbar-client
branch
from
8a25833 to
e3839a1
Compare
cspath1
reviewed
Nov 14, 2025
Contributor
cspath1
left a comment
cspath1
left a comment
There was a problem hiding this comment.
This is great!! I do think we will want to add env variables (probably via terraform) for where the toolbar env variables will come from during the CI/CD process. Other than that, this is such an exciting update that opens the door for a whole lot of awesome features moving forward!
| @@ -0,0 +1,129 @@ | |||
| import { describe, test, expect, vi, beforeEach } from 'vitest'; | |||
Contributor
There was a problem hiding this comment.
should we move this into the tests folder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for an internal LaunchDarkly client within the toolbar package, enabling toolbar-specific feature flags and analytics tracking. The internal client is separate from the user's application client and can be optionally configured via environment variables.
What does this PR do?
InternalClientProvidercomponent to manage the toolbar's internal LaunchDarkly clientcreateToolbarFlagFunctionfor type-safe access to toolbar feature flagsType of Change
Screenshots/Videos