Skip to content

Commit e3839a1

Browse files
test: fix broken tests
1 parent 207e1c5 commit e3839a1

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

packages/toolbar/src/core/tests/ExpandedToolbarContent.test.tsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { DevServerProvider } from '../ui/Toolbar/context/DevServerProvider';
66
import { ToolbarUIProvider } from '../ui/Toolbar/context/ToolbarUIProvider';
77
import { SearchProvider } from '../ui/Toolbar/context/SearchProvider';
88
import { AnalyticsProvider } from '../ui/Toolbar/context/AnalyticsProvider';
9+
import { InternalClientProvider } from '../ui/Toolbar/context/InternalClientProvider';
910
import { IEventInterceptionPlugin, IFlagOverridePlugin } from '../../types';
1011

1112
// Create mock instances that we can access in tests
@@ -91,9 +92,11 @@ function TestWrapper({
9192
pollIntervalInMs: 5000,
9293
}}
9394
>
94-
<AnalyticsProvider>
95-
<SearchProvider>{children}</SearchProvider>
96-
</AnalyticsProvider>
95+
<InternalClientProvider>
96+
<AnalyticsProvider>
97+
<SearchProvider>{children}</SearchProvider>
98+
</AnalyticsProvider>
99+
</InternalClientProvider>
97100
</DevServerProvider>
98101
</ToolbarUIProvider>
99102
);
@@ -115,6 +118,8 @@ describe('ExpandedToolbarContent - User Interaction Flows', () => {
115118
onTabChange: vi.fn(),
116119
setSearchIsExpanded: vi.fn(),
117120
defaultActiveTab: 'settings' as const,
121+
optInToNewFeatures: false,
122+
onToggleOptInToNewFeatures: vi.fn(),
118123
};
119124

120125
const createMockFlagOverridePlugin = (): IFlagOverridePlugin & {

packages/toolbar/src/core/tests/InternalClientProvider.test.tsx

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ describe('InternalClientProvider', () => {
8585
describe('Initialization', () => {
8686
test('initializes client successfully with valid clientSideID', async () => {
8787
render(
88-
<InternalClientProvider clientSideID="test-client-id-123">
88+
<InternalClientProvider clientSideId="test-client-id-123">
8989
<TestConsumer />
9090
</InternalClientProvider>,
9191
);
@@ -105,7 +105,7 @@ describe('InternalClientProvider', () => {
105105

106106
test('calls setToolbarFlagClient on successful initialization', async () => {
107107
render(
108-
<InternalClientProvider clientSideID="test-client-id-123">
108+
<InternalClientProvider clientSideId="test-client-id-123">
109109
<TestConsumer />
110110
</InternalClientProvider>,
111111
);
@@ -117,7 +117,7 @@ describe('InternalClientProvider', () => {
117117

118118
test('initializes with default anonymous context when no initialContext provided', async () => {
119119
render(
120-
<InternalClientProvider clientSideID="test-client-id-123">
120+
<InternalClientProvider clientSideId="test-client-id-123">
121121
<TestConsumer />
122122
</InternalClientProvider>,
123123
);
@@ -143,7 +143,7 @@ describe('InternalClientProvider', () => {
143143
};
144144

145145
render(
146-
<InternalClientProvider clientSideID="test-client-id-123" initialContext={customContext}>
146+
<InternalClientProvider clientSideId="test-client-id-123" initialContext={customContext}>
147147
<TestConsumer />
148148
</InternalClientProvider>,
149149
);
@@ -159,7 +159,7 @@ describe('InternalClientProvider', () => {
159159
mockLDClient.waitForInitialization.mockRejectedValueOnce(initError);
160160

161161
render(
162-
<InternalClientProvider clientSideID="invalid-client-id">
162+
<InternalClientProvider clientSideId="invalid-client-id">
163163
<TestConsumer />
164164
</InternalClientProvider>,
165165
);
@@ -179,7 +179,7 @@ describe('InternalClientProvider', () => {
179179
mockLDClient.waitForInitialization.mockRejectedValueOnce(new Error('Init failed'));
180180

181181
render(
182-
<InternalClientProvider clientSideID="invalid-client-id">
182+
<InternalClientProvider clientSideId="invalid-client-id">
183183
<TestConsumer />
184184
</InternalClientProvider>,
185185
);
@@ -197,23 +197,21 @@ describe('InternalClientProvider', () => {
197197
describe('Custom Base URL Configuration', () => {
198198
test('configures SDK with custom baseUrl when provided', async () => {
199199
render(
200-
<InternalClientProvider clientSideID="test-client-id-123" baseUrl="https://app.ld.catamorphic.com">
200+
<InternalClientProvider clientSideId="test-client-id-123" baseUrl="https://app.ld.catamorphic.com">
201201
<TestConsumer />
202202
</InternalClientProvider>,
203203
);
204204

205205
await waitFor(() => {
206206
expect(mockInitialize).toHaveBeenCalledWith('test-client-id-123', expect.any(Object), {
207207
baseUrl: 'https://app.ld.catamorphic.com',
208-
streamUrl: 'https://clientstream.ld.catamorphic.com',
209-
eventsUrl: 'https://events.ld.catamorphic.com',
210208
});
211209
});
212210
});
213211

214212
test('does not provide options when baseUrl is not specified', async () => {
215213
render(
216-
<InternalClientProvider clientSideID="test-client-id-123">
214+
<InternalClientProvider clientSideId="test-client-id-123">
217215
<TestConsumer />
218216
</InternalClientProvider>,
219217
);
@@ -227,7 +225,7 @@ describe('InternalClientProvider', () => {
227225
describe('Cleanup', () => {
228226
test('clears singleton and closes client on unmount', async () => {
229227
const { unmount } = render(
230-
<InternalClientProvider clientSideID="test-client-id-123">
228+
<InternalClientProvider clientSideId="test-client-id-123">
231229
<TestConsumer />
232230
</InternalClientProvider>,
233231
);
@@ -246,7 +244,7 @@ describe('InternalClientProvider', () => {
246244
describe('useInternalClient Hook', () => {
247245
test('returns client, loading, and error state', async () => {
248246
render(
249-
<InternalClientProvider clientSideID="test-client-id-123">
247+
<InternalClientProvider clientSideId="test-client-id-123">
250248
<TestConsumer />
251249
</InternalClientProvider>,
252250
);
@@ -276,7 +274,7 @@ describe('InternalClientProvider', () => {
276274
describe('useInternalClientInstance Hook', () => {
277275
test('returns client instance when initialized', async () => {
278276
render(
279-
<InternalClientProvider clientSideID="test-client-id-123">
277+
<InternalClientProvider clientSideId="test-client-id-123">
280278
<TestClientInstanceConsumer />
281279
</InternalClientProvider>,
282280
);
@@ -288,7 +286,7 @@ describe('InternalClientProvider', () => {
288286

289287
test('returns null before initialization', () => {
290288
render(
291-
<InternalClientProvider clientSideID="test-client-id-123">
289+
<InternalClientProvider clientSideId="test-client-id-123">
292290
<TestClientInstanceConsumer />
293291
</InternalClientProvider>,
294292
);

0 commit comments

Comments
 (0)