Skip to content

chore: Port to sigs.k8s.io/yaml #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/krel/cmd/release_notes.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ import (
gogit "github.com/go-git/go-git/v5"
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"gopkg.in/yaml.v2"

"sigs.k8s.io/release-sdk/git"
"sigs.k8s.io/release-sdk/github"
"sigs.k8s.io/release-utils/command"
"sigs.k8s.io/release-utils/editor"
"sigs.k8s.io/release-utils/util"
"sigs.k8s.io/yaml"

"k8s.io/release/pkg/notes"
"k8s.io/release/pkg/notes/document"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ require (
golang.org/x/oauth2 v0.29.0
golang.org/x/text v0.24.0
google.golang.org/api v0.221.0
gopkg.in/yaml.v2 v2.4.0
k8s.io/apimachinery v0.32.3
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
sigs.k8s.io/bom v0.6.0
Expand Down Expand Up @@ -311,6 +310,7 @@ require (
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/ini.v1 v1.67.0 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/api v0.28.4 // indirect
k8s.io/client-go v0.28.4 // indirect
Expand Down
2 changes: 1 addition & 1 deletion pkg/cve/impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ import (

"cloud.google.com/go/storage"
"github.com/sirupsen/logrus"
"gopkg.in/yaml.v2"

"sigs.k8s.io/release-sdk/object"
"sigs.k8s.io/yaml"

"k8s.io/release/pkg/notes"
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/notes/notes.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ import (
"github.com/sirupsen/logrus"
"golang.org/x/text/cases"
"golang.org/x/text/language"
"gopkg.in/yaml.v2"

"sigs.k8s.io/release-sdk/github"
"sigs.k8s.io/yaml"

"k8s.io/release/pkg/notes/options"
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/notes/notes_map.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ import (
"path/filepath"

"github.com/sirupsen/logrus"
"gopkg.in/yaml.v2"

"sigs.k8s.io/release-sdk/object"
yaml "sigs.k8s.io/yaml/goyaml.v2"
Copy link
Member Author

@mrueg mrueg Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato this uses NewDecoder which is not directly available in ghodds/yaml / sigs.k8s.io/yaml

)

// MapProvider interface that obtains release notes maps from a source.
Expand Down
Loading