Skip to content

chore: Port to sigs.k8s.io/yaml #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Port to sigs.k8s.io/yaml #3994

wants to merge 1 commit into from

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Apr 24, 2025

What type of PR is this?

/kind cleanup

/kind deprecation

What this PR does / why we need it:

Ports from unmaintained gopkg.in/yaml.v2 to sigs.k8s.io/yaml.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 24, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jimangel April 24, 2025 19:57
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi April 24, 2025 19:57
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2025
@mrueg mrueg force-pushed the port-away-from-gopkg.in-yaml-v2 branch from 955f119 to ff8829a Compare April 24, 2025 19:58
cpanato
cpanato requested changes Apr 25, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this

as you are replacing this can you move to straight to "sigs.k8s.io/yaml" and not use the v2?

@mrueg mrueg force-pushed the port-away-from-gopkg.in-yaml-v2 branch from ff8829a to 22fea09 Compare April 26, 2025 19:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrueg
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrueg mrueg force-pushed the port-away-from-gopkg.in-yaml-v2 branch from 22fea09 to 7ebc4ea Compare April 26, 2025 19:24
mrueg
mrueg commented Apr 26, 2025
View reviewed changes
pkg/notes/notes_map.go

"sigs.k8s.io/release-sdk/object"
yaml "sigs.k8s.io/yaml/goyaml.v2"
Copy link
Member Author

@mrueg mrueg Apr 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato this uses NewDecoder which is not directly available in ghodds/yaml / sigs.k8s.io/yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato requested changes

@jimangel jimangel Awaiting requested review from jimangel

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@cpanato cpanato

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrueg @k8s-ci-robot @cpanato