Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document component-standard issues /w custom content #4138

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Document component-standard issues /w custom content #4138

merged 1 commit into from
Jan 29, 2020

Conversation

stealthybox
Copy link
Member

Fixes #4117
/kind documentation
/wg component-standard
/sig cluster-lifecycle

This patch uses custom content.
The trade-off is that the information is at the bottom. Not everyone reads until the end.
Alternative to #4137

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2019
@nikhita nikhita mentioned this pull request Oct 7, 2019
Closed
@nikhita
Copy link
Member

nikhita commented Oct 7, 2019

/assign @mtaufen @sttts

nikhita
nikhita reviewed Oct 7, 2019
View reviewed changes
wg-component-standard/README.md Outdated
Issues are opened in [k/k](https://github.com/kubernetes/kubernetes) or the appropriate project/component repo with the `wg/component-standard` label.
To apply this label to an issue using Prow, leave a comment containing `/wg component-standard` on its own line.

[k/component-base](https://github.com/kubernetes/component-base) is an automated staging repository managed from the ./staging directory in [k/k](https://github.com/kubernetes/kubernetes). Issues are not currently looked at on this repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea: we could add a note in the component-base README about opening issues directly in k/k and disable issues in the repo (it's an option in Settings). Disabling issues would remove the "Issues" tab from the repo completely. Given that there haven't been any significant issues (only kubernetes/component-base#2) created in the repo, I don't think this should be a problem...

@stealthybox wdyt?

IIRC we haven't disabled issues on any of the staging repos in the past though. cc @kubernetes/owners

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SGTM

@mtaufen
Copy link
Contributor

mtaufen commented Oct 8, 2019

@stealthybox nice addition, thanks. Agree w/ @nikhita's comments

@dims
Copy link
Member

dims commented Oct 16, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims October 16, 2019 13:44
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@markjacksonfishing
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@parispittman
Copy link
Contributor

@stealthybox looks like you have one more comment left from nikhita and ready to merge

@stealthybox
Copy link
Member Author

@parispittman, thanks -- just patched @nikhita's suggestion

nikhita
nikhita approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, stealthybox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 682338d into kubernetes:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@nikhita nikhita nikhita approved these changes

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

Assignees

@sttts sttts

@mtaufen mtaufen

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to Find Component Standard Issues
9 participants
@stealthybox @nikhita @mtaufen @dims @fejta-bot @markjacksonfishing @parispittman @k8s-ci-robot @sttts