-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generator for issues -- Update WG Component Standard #4137
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stealthybox The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stealthybox Thanks for the PR! Left some thoughts on why using markdown directly might be better. PTAL.
k/k Issues / PR's needing Review: https://github.com/kubernetes/kubernetes/issues?utf8=%E2%9C%93&q=label%3Awg%2Fcomponent-standard+ | ||
description: "Issues are opened in [k/k](https://github.com/kubernetes/kubernetes) | ||
or the appropriate project/component repo with the `wg/component-standard` label. | ||
\ \nTo apply this label to an issue using Prow, leave a comment containing `/wg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the custom content approach (#4138) would be preferable over adding a new field to the generator, since this format of issue triage might not hold true for other SIGs/WGs (for instance, the SIG Cluster Lifecycle link mentioned below).
The generator approach also requires lengthy descriptions in yaml files. The newline formatting would also be easier to handle if we directly use markdown files.
Another alternative is to setup a separate doc for issue triage like https://github.com/kubernetes/community/blob/master/sig-cluster-lifecycle/grooming.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stealthybox closing this in favour of #4138. Please reopen if you'd like to discuss ^^ further. :)
/close
@nikhita: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #4117
/kind documentation
/wg component-standard
/sig cluster-lifecycle
This patch modifies the generator app to support Issues