Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator for issues -- Update WG Component Standard #4137

Closed
wants to merge 1 commit into from

Conversation

stealthybox
Copy link
Member

@stealthybox stealthybox commented Oct 2, 2019

Fixes #4117
/kind documentation
/wg component-standard
/sig cluster-lifecycle

This patch modifies the generator app to support Issues

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/documentation Categorizes issue or PR as related to documentation. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stealthybox
To complete the pull request process, please assign brendandburns
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2019
@stealthybox stealthybox changed the title Add issues documentation for WG Component Standard Add generator for issues -- Update WG Component Standard Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • d2275a5 Document component-standard issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stealthybox Thanks for the PR! Left some thoughts on why using markdown directly might be better. PTAL.

/assign @nikhita @cblecker

k/k Issues / PR's needing Review: https://github.com/kubernetes/kubernetes/issues?utf8=%E2%9C%93&q=label%3Awg%2Fcomponent-standard+
description: "Issues are opened in [k/k](https://github.com/kubernetes/kubernetes)
or the appropriate project/component repo with the `wg/component-standard` label.
\ \nTo apply this label to an issue using Prow, leave a comment containing `/wg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the custom content approach (#4138) would be preferable over adding a new field to the generator, since this format of issue triage might not hold true for other SIGs/WGs (for instance, the SIG Cluster Lifecycle link mentioned below).

The generator approach also requires lengthy descriptions in yaml files. The newline formatting would also be easier to handle if we directly use markdown files.

Another alternative is to setup a separate doc for issue triage like https://github.com/kubernetes/community/blob/master/sig-cluster-lifecycle/grooming.md.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stealthybox closing this in favour of #4138. Please reopen if you'd like to discuss ^^ further. :)

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closed this PR.

In response to this:

@stealthybox closing this in favour of #4138. Please reopen if you'd like to discuss ^^ further. :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/documentation Categorizes issue or PR as related to documentation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to Find Component Standard Issues
4 participants