Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-cloud-provider: s/sig-<provider>-leads/provider-<provider> in OWNERS #3941

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 30, 2019

Adds custom content OWNERS for former cloud provider SIG Chairs/TLs

There may have been a more elegant way to do this, but here's what I did:

for provider in "aws" "azure" "gcp" "ibmcloud" "openstack" "vmware"; do 
  for i in $(grep --exclude-dir=.git -lR sig-${provider}-leads .); do
    sed -i "s/sig-${provider}-leads/provider-${provider}/g" "$i";
  done
done

/assign @andrewsykim @nikhita

Ref: #3895, kubernetes/org#1050, kubernetes/org#1051

Signed-off-by: Stephen Augustus [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. sig/aws area/provider/azure Issues or PRs related to azure provider area/provider/ibmcloud Issues or PRs related to ibmcloud provider area/provider/openstack Issues or PRs related to openstack provider area/provider/vmware Issues or PRs related to vmware provider do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 30, 2019
Neither are kubernetes org members

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 30, 2019
@nikhita
Copy link
Member

nikhita commented Jul 30, 2019

@justaugustus is there a timeline for when the deprecated SIG READMEs/tombstones can be removed?

@justaugustus
Copy link
Member Author

@justaugustus is there a timeline for when the deprecated SIG READMEs/tombstones can be removed?

@nikhita -- added tombstones for 1.17 in 4b02fa4.

@justaugustus
Copy link
Member Author

/assign @parispittman @cblecker

@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b365e5b into kubernetes:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider area/provider/ibmcloud Issues or PRs related to ibmcloud provider area/provider/openstack Issues or PRs related to openstack provider area/provider/vmware Issues or PRs related to vmware provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants