Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-cloud-provider: Rename OWNERS_ALIASES & GitHub teams #1052

Merged
merged 3 commits into from
Jul 30, 2019
Merged

sig-cloud-provider: Rename OWNERS_ALIASES & GitHub teams #1052

merged 3 commits into from
Jul 30, 2019

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 30, 2019 •
edited
Loading

  • OWNERS: Update OWNER_ALIASES from k/community
  • sig-cloud-provider: Update OWNER_ALIASES for consolidated SIGs
  • sig-cloud-provider: Update GitHub teams for consolidated SIGs

Ref: kubernetes/community#3941, kubernetes/community#3895, #1051

/assign @andrewsykim @nikhita

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. area/provider/gcp Issues or PRs related to gcp provider area/provider/ibmcloud Issues or PRs related to ibmcloud provider area/provider/openstack Issues or PRs related to openstack provider area/provider/vmware Issues or PRs related to vmware provider do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 30, 2019
@nikhita
Copy link
Member

nikhita commented Jul 30, 2019

Re the invalid-owners-file label: even though some of the people mentioned in #1052 (comment) are not added/removed in this PR, they are flagged because the plugin looks at the patch: https://github.com/kubernetes/org/pull/1052.patch

See kubernetes/community#3923 (comment) for more details.

@justaugustus I'm ok with manually removing the label for now (since it's unrelated to this change) and then following up to make sure that all SIG/WG/UG leads are members of the Kubernetes org in an issue. Let me know if this sgty!

@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

  • hannibalhuang
    • OWNERS_ALIASES
  • mdelder
    • OWNERS_ALIASES
  • ptone
    • OWNERS_ALIASES
  • tsandall
    • OWNERS_ALIASES
  • aasmall
    • OWNERS_ALIASES
  • cindyxing
    • OWNERS_ALIASES
  • ericavonb
    • OWNERS_ALIASES
  • jaybeale
    • OWNERS_ALIASES
  • cji
    • OWNERS_ALIASES
  • dejanb
    • OWNERS_ALIASES
  • easeway
    • OWNERS_ALIASES

@justaugustus
Copy link
Member Author

@justaugustus I'm ok with manually removing the label for now (since it's unrelated to this change) and then following up to make sure that all SIG/WG/UG leads are members of the Kubernetes org in an issue. Let me know if this sgty!

@nikhita -- SGTM!

This was referenced Jul 30, 2019
Closed
Merged
@nikhita nikhita removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 30, 2019
@nikhita
Copy link
Member

nikhita commented Jul 30, 2019

/lgtm
/approve

/hold
until kubernetes/community#3941 merges

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@justaugustus justaugustus mentioned this pull request Jul 30, 2019
Closed
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b4016c7 into kubernetes:master Jul 30, 2019
@nikhita nikhita mentioned this pull request Jul 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@abgworrall abgworrall Awaiting requested review from abgworrall

@cantbewong cantbewong Awaiting requested review from cantbewong

Assignees

@andrewsykim andrewsykim

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/provider/ibmcloud Issues or PRs related to ibmcloud provider area/provider/openstack Issues or PRs related to openstack provider area/provider/vmware Issues or PRs related to vmware provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @nikhita @k8s-ci-robot @andrewsykim