test(runtime): add UT for torch runtime valid function. #2560
+234
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 14072356914Details
💛 - Coveralls |
IRONICBo
changed the title
IRONICBo
force-pushed
the
bo/test/add-ut-for-torch-runtime-valid
branch
4 times, most recently
from
080c566 to
3bde232
Compare
tenzen-y
reviewed
Mar 25, 2025
IRONICBo
force-pushed
the
bo/test/add-ut-for-torch-runtime-valid
branch
2 times, most recently
from
00e6740 to
5a38dda
Compare
tenzen-y
reviewed
Mar 25, 2025
pkg/util/testing/wrapper.go
Outdated
Comment on lines
1021
to
1025
| // For no numProcPerNode UT scenario | ||
| var numProcPerNodePtr *intstr.IntOrString | ||
| if numProcPerNode != "" { | ||
| numProcPerNodePtr = ptr.To(intstr.FromString(numProcPerNode)) | ||
| } |
There was a problem hiding this comment.
Instead of these hacking, we could use numProcPerNode as a pointer like
func (m *MLPolicySourceWrapper) TorchPolicy(numProcPerNode *intstr.IntOrString, elasticPolicy *trainer.TorchElasticPolicy) *MLPolicySourceWrapper {
There was a problem hiding this comment.
Thanks, I have removed it and replaced them like TorchPolicy(ptr.To(intstr.FromString("auto")), nil).
Signed-off-by: Asklv <[email protected]>
IRONICBo
force-pushed
the
bo/test/add-ut-for-torch-runtime-valid
branch
from
5a38dda to
56d9144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add specific UT for torch runtime
Validfunction.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2556
Checklist:
PTAL, @tenzen-y