Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add IRONICBo as member. #761

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

IRONICBo
Copy link
Contributor

@IRONICBo IRONICBo commented Mar 22, 2025

Links to PRs:

Pytest output:

  pytest test_org_yaml.py
======================================================================================== test session starts =========================================================================================
platform linux -- Python 3.12.4, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/lvbo/project/aik8s/internal-acls/github-orgs
plugins: anyio-4.8.0
collected 1 item                                                                                                                                                                                     

test_org_yaml.py .                                                                                                                                                                             [100%]

========================================================================================= 1 passed in 0.11s ==========================================================================================

PTAL @andreyvelich @tenzen-y @Electronic-Waste

Copy link

Hi @IRONICBo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Electronic-Waste
Copy link
Member

Thanks for your great contributions! And welcome to the Kubeflow Community!

/lgtm
/ok-to-test
/assign @kubeflow/wg-training-leads @astefanutti

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contributions @IRONICBo 🎉

- IronPan
- IRONICBo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep list alphabetical.

Suggested change
- IronPan
- IRONICBo
- IRONICBo
- IronPan

Copy link
Contributor Author

@IRONICBo IRONICBo Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks, I have fixed it. @andreyvelich

@andreyvelich
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ff31ab0 into kubeflow:master Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants