Implement CustomValidation UT for MPI plugin #2555
Conversation
Pull Request Test Coverage Report for Build 13992886013Details
💛 - Coveralls |
|
/assign @kubeflow/wg-training-leads @astefanutti |
| allErrs = append(allErrs, field.Invalid(numProcPerNodePath, newJobObj.Spec.Trainer.NumProcPerNode, "must have an int value")) | ||
| if trainJobTrainer := newJobObj.Spec.Trainer; trainJobTrainer != nil && trainJobTrainer.NumProcPerNode != nil { | ||
| if trainJobTrainer.NumProcPerNode.Type != intstr.Int { | ||
| allErrs = append(allErrs, field.Invalid(numProcPerNodePath, *trainJobTrainer.NumProcPerNode, "must have an int value")) |
There was a problem hiding this comment.
Not strictly in the scope of that PR, but while we are at it, maybe the error message could be more specific, e.g. "must have an int value for MPI job".
There was a problem hiding this comment.
Good point, let me contain your request in this PR.
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
implement-validation-uts
branch
from
13deb16 to
171872f
Compare
|
@kubeflow/wg-training-leads @astefanutti @Electronic-Waste Can anyone add lgtm tag? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Part of #2556
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: