Implement UTs for Plugin CustomValidations

[tenzen-y]

What you would like to be added?

It would be great to add more fine-grained UTs for CustomValidations in each plugin.

• MPI: @tenzen-y
  • Target Function:

    trainer/pkg/runtime/framework/plugins/mpi/mpi.go

    Line 82 in 8aa97a4

    func (m *MPI) Validate(_ client.Object, runtimeInfo *runtime.Info, _, newJobObj *trainer.TrainJob) (admission.Warnings, field.ErrorList) {

  • PR: Implement CustomValidation UT for MPI plugin #2555
• JobSet: @Harshal292004
  • Target Function:

    trainer/pkg/runtime/framework/plugins/jobset/jobset.go

    Line 78 in 8aa97a4

    func (j *JobSet) Validate(runtimeJobTemplate client.Object, runtimeInfo *runtime.Info, oldObj, newObj *trainer.TrainJob) (admission.Warnings, field.ErrorList) {

  • PR:
• Torch: @IRONICBo
  • Target Function:

    trainer/pkg/runtime/framework/plugins/torch/torch.go

    Line 55 in 8aa97a4

    func (t *Torch) Validate(_ client.Object, runtimeInfo *runtime.Info, _, newObj *trainer.TrainJob) (admission.Warnings, field.ErrorList) {

  • PR: test(runtime): add UT for torch runtime valid function. #2560

Why is this needed?

This allows us to strictly verify whether or not each validation works correctly.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

[tenzen-y]

If anyone wants to take either plugin, please reach out to me.
I can assign one of them to you.

[Harshal292004]

@tenzen-y May I take the MPI and JobSet Plugins

[tenzen-y]

@tenzen-y May I take the MPI and JobSet Plugins

MPI already has been opened. So, I can assign JobSet to you.

[IRONICBo]

Please assign Torch to me, Thanks! @tenzen-y.

[tenzen-y]

Please assign Torch to me, Thanks! @tenzen-y.

Sure, I assigned Torch to you

[tenzen-y]

/assign @tenzen-y @Harshal292004 @IRONICBo

[Harshal292004]

@tenzen-y What exactly needs to be done here ?

[Harshal292004]

Do I need to increase the test coverage for JobSet validation?

[IRONICBo]

Do I need to increase the test coverage for JobSet validation?

I think you are right, we can refer to @tenzen-y PR , #2555.

[Garvit-77]

Hey @tenzen-y , Could you assign me jobset ?

[Harshal292004]

Hey @Garvit-77 I am working on that

[tenzen-y]

/reopen

[google-oss-prow]

@tenzen-y: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.