This repository was archived by the owner on Dec 1, 2018. It is now read-only.

Fix `<ctype.h>` arguments#58

Open

Sebbyastian wants to merge 274 commits intokristapsdz:masterfrom

Sebbyastian:patch-3

This pull request is big! We're only showing the most recent 250 commits

Commits on May 15, 2016

Look again at the relinquishing of privilege. Move privilege-dropping
kristaps
committed
Consistency in naming "Let's Encrypt".
kristaps
committed
Documents key bits.
kristaps
committed
Catch error return code.
kristaps
committed
Add more documentation.
kristaps
committed
More documentation.
kristaps
committed
Properly catch when the challenge has been verified.
kristaps
committed
Fix a segfault.
kristaps
committed
Function attributes for messages.
kristaps
committed
Add forgotten waitpid for COMP_FILE and add some readops to make sure that
kristaps
committed
Reduce the number of pledges in chngproc.
kristaps
committed
Continue minimising the pledges.
kristaps
committed
Drop privs in the correct order and make sure sys_signame is not used on Linux.
kristaps
committed
Linux compatibility.
kristaps
committed
Fully demonstrate that chroot doesn't work on Linux for netproc.
kristaps
committed
Catch __attribute__ warnings.
kristaps
committed
Documentation on Linux.
kristaps
committed
Fix for https://github.com/kristapsdz/letskencrypt/pull/1 posted by
kristaps
committed

Commits on May 16, 2016

Fix typo found by Anthony Bentley--thanks!
kristaps
committed
Initial check-in of a separate process for DNS management.
kristaps
committed
Add the dnsproc manager. This was noted by deraadt@. This does nothing but
kristaps
committed
Push the DNS resolution into one function for clarity.
kristaps
committed
Fix an off-by-one and also fix closing the DNS file descriptor.
kristaps
committed
Account key doesn't need read permissions.
kristaps
committed
Remove comment that no longer belongs.
kristaps
committed
We don't close any fds before the out, so don't check them against -1.
kristaps
committed
Don't let the testing code make it out.
kristaps
committed
Clean up the README.
kristaps
committed
Update notes on dnsproc.
kristaps
committed
More documentation notes on why Linux and Mac OS X are a bad idea.
kristaps
committed
Fix CID 111100.
kristaps
committed
Fix CID 111099.
kristaps
committed
Have dnsproc properly return (and not exit) like the other processes.
kristaps
committed
Add a secret and undocumented feature that allows me to create files in the
kristaps
committed
Be more terse in the implementation notes.
kristaps
committed
Update README a bit.
kristaps
committed
Add some media for the GH site and fix a mistake in the manpage.
kristaps
committed
Have the keyproc and acctproc notify the netproc when they've started, and
kristaps
committed
Calm down people afraid of root.
kristaps
committed
Failing start-up for account or key proc doesn't error us.
kristaps
committed
When closing out, close sockets first to cause depending processes to bail earlier.
kristaps
committed
Continue to polish the documentation.
kristaps
committed
Initial steps of revocation. This is pretty straightforward.
kristaps
committed

Commits on May 17, 2016

Continue making operations more semantically meaningful.
kristaps
committed
Continue cleaning up operations (in netproc).
kristaps
committed
Add in the initial framework for checking certificate revocation times.
kristaps
committed
Have chngproc's magic testing phase (which isn't an official option) not
kristaps
committed
Check for expiration date of certificate, if found. This makes it possible
kristaps
committed
Re-add accidentally-removed check for certificate non-expiration.
kristaps
committed
Plug still-open fd.
kristaps
committed
Add note on revokeproc to manpage.
kristaps
committed

Commits on May 18, 2016

Finish the revocation function. Also, start to lay the groundwork for
kristaps
committed
Split all sandbox operations into their own file. This is part of the
kristaps
committed
Start stripping out compatibility, which is now in letskencrypt-portable.
kristaps
committed
Clean up the Makefile now that we have less cruft.
kristaps
committed
Add forgotten break statement.
kristaps
committed
Catch buffers larger than BUFSIZ bytes.
kristaps
committed
Require OpenBSD >= 5.9.
kristaps
committed
Update the manpage with revocation instructions.
kristaps
committed
Note that we now do revocation.
kristaps
committed
FreeBSD nit. This will be smoothed out in subsequent improvement of -portable.
kristaps
committed
Note -portable and FreeBSD.
kristaps
committed
Fix broken link.
kristaps
committed
Move setresuid goop into -portable.
kristaps
committed
Start using setproctitle(). First step in kicking out dbg.c.
kristaps
committed
kristaps
committed
Kick out dowarn in favour of warn.
kristaps
committed
Remove all logging in favour of warnx et al.
kristaps
committed
Use strsignal() instead of a hack.
kristaps
committed
Allow overriding the priv-drop user.
kristaps
committed

Commits on May 19, 2016

No functional change: just order getopt() parameters for easier search.
kristaps
committed
Push communication-related parameters into struct conn. Makes the code a
kristaps
committed
Remove debugging message.
kristaps
committed
Significantly clean up the handling of HTTP document bodies: first, only
kristaps
committed
Remove the coverity note (that's going into the -portable version).
kristaps
committed
Forgot to close revokeproc channel.
kristaps
committed
Make filenames in debug messages more meaningful.
kristaps
committed
Fix how SAN is registered with the key. In prior versions, we were having
kristaps
committed
Flip on real versus staging servers. bsd.lv is now eating its dogfood.
kristaps
committed
Document the -s flag.
kristaps
committed
We're no longer just using the staging server. Here we go!
kristaps
committed
Have writeop, writestr, and writebuf all return -1 on failure, 0 on end
kristaps
committed
Have the writer functions notify us whether the reader has exited.
kristaps
committed
Have revokeproc properly handle the case where the reader fails.
kristaps
committed
Last nit: make writestr also be ok if the reader has exited.
kristaps
committed
Have acctproc properly handle reader termination.
kristaps
committed
Rename label to "out" (consistency) and allow for reader failure.
kristaps
committed
Convert certproc to ignore reader failure.
kristaps
committed
Convert chngproc to ignore reader failure.
kristaps
committed

Commits on May 20, 2016

Commits on May 22, 2016

It's not clear whether the lengths returned by the BIO are
kristaps
committed
Add JSMN: https://github.com/zserge/jsmn.
kristaps
committed
Put license directly into jsmn.c and jsmn.h, just to be clear about it.
kristaps
committed
Kick out json-c in favour of jsmn (with an array->tree wrapper).
kristaps
committed
Note use of MIT license in JSMN's files.
kristaps
committed

Commits on May 24, 2016

Start to kick out libcurl with a small HTTP client originally inspired by
kristaps
committed
Missing header for compilation.
kristaps
committed
Continue fleshing out http.h implementation.
kristaps
committed
Have dnsproc transfer both the IP/IPv6 to netproc and also the family itself.
kristaps
committed
Max the maximum DNS entries be globally known and also add the new dnsproc
kristaps
committed
Stop using curl, and instead use the home-grown http.c and -tls.
kristaps
committed
Weaken TLS validation. Is this necessary?
kristaps
committed
Initial [working] removal of curl from netproc. This replaces the nreq()
kristaps
committed
Don't use strdup() for bodies--they can be binary.
kristaps
committed
Fix lib.
kristaps
committed
For the time being, allow tls_read/write to be ifdef'd for two different
kristaps
committed
Needed for compat glue.
kristaps
committed
Change feature test.
kristaps
committed
Clean up the readme notes.
kristaps
committed

Commits on May 25, 2016

Cache the last DNS response and return that, if the subsequent request is
kristaps
committed
Make sure the connection is closed as soon as the body is read and also
kristaps
committed
Have sreq and nreq return the HTTP error or -1, remove some debugging messages,
kristaps
committed
Fix scanning ahead for SAN DNS entries.
kristaps
committed
Figure out what tls_close does with the socket.
kristaps
committed
Try to close connection properly.
kristaps
committed

Commits on May 26, 2016

"Embrace the pledge".
kristaps
committed
What's the point of dropping root privileges if root can't do anything?
kristaps
committed
Make the compiler happy.
kristaps
committed
Rename chroot-pledge into util-pledge, which is more appropriate.
kristaps
committed

Commits on Jun 1, 2016

Fix usage. patch by Caspar Schutijser--thanks!
kristaps
committed
Remove comment about rename(2) (ack'd by deraadt@) and remove rpath from
kristaps
committed
Re-add chroot(2) for file process and challenge process. This is because
kristaps
committed
The user-drop now occurs only in the -portable code, so we don't want to
kristaps
committed
Fix compilation.
kristaps
committed
Prune out setting a user: this is no longer necessary as all procs not
kristaps
committed
Remove implementation notes. Suggested by deraadt@ among others.
kristaps
committed
Kick out a lot of old header files we don't use any more.
kristaps
committed

Commits on Jun 2, 2016

Commits on Jun 3, 2016

Commits on Jun 25, 2016

Do what the documentation says regarding -v -v and dump buffers.
kristaps
committed
Introduce -m (not documented while I test it) that appends the initial
kristaps
committed
Don't modify the input buffer when tracing!
kristaps
committed
Document multi-domain setup.
kristaps
committed
Initialise variable and also downgrade "cached" message to trace mode.
kristaps
committed
Memory leak in error path.
kristaps
committed
Note RSA-specific functions as patched by Remco---thanks!
kristaps
committed
Split out more RSA-specific functions, from a modified patch by Remco---thanks!
kristaps
committed
Also move the key creation into an RSA-specific format, directly from a
kristaps
committed

Commits on Jun 28, 2016

Update to note NetBSD.
kristaps
committed
Have creation of account key be properly umasked. From a patch by Remco---thanks!
kristaps
committed

Commits on Jul 2, 2016

Use isalnum instead of isalpha for domain name validation. Submitted by
kristaps
committed
OpenBSD 5.7 needs stdint.h for uintptr_t.
kristaps
committed
On OpenBSD 5.7, tls_read and family behave strangely: account for that.
kristaps
committed

Commits on Jul 10, 2016

Add some example usage.
kristaps
committed

Commits on Jul 12, 2016

Beginning of code to let the keyproc create a new RSA domain key. This was
kristaps
committed
Cosmetic fix.
kristaps
committed
Move rsa key creation and loading into their own file (and header) for
kristaps
committed
Adding key creation to keyproc.
kristaps
committed
Note domain key, not account key.
kristaps
committed
Turn on domain key creation.
kristaps
committed
Add manual bits for -N, domain key registration.
kristaps
committed
Fix access invocation.
kristaps
committed
Silence a coverity issue. No logical change.
kristaps
committed

Commits on Jul 13, 2016

Add check for extended error code (i.e., exit status of 2).
kristaps
committed
Return a special error code when we update certificates.
kristaps
committed
Fix usage message, fix error message to be a bit more useful (as noted in
kristaps
committed
Note new exit codes, change "mkdir -m" for mkdir and chmod (not all systems
kristaps
committed
Fix example and reorder exit status documentation.
kristaps
committed

Commits on Jul 16, 2016

Commits on Jul 28, 2016

Initial backing-up of certificates.
kristaps
committed
Document backing up.
kristaps
committed

Commits on Aug 6, 2016

Adding override for agreement with -a flag. Noted (and partially patched) in
kristaps
committed
Allow overriding agreement and also update usage message.
kristaps
committed
Document -a.
kristaps
committed
Allow a fake-install prefix. From https://github.com/kristapsdz/letskencrypt/pull/16 .
kristaps
committed

Commits on Aug 19, 2016

Merge https://github.com/kristapsdz/letskencrypt-portable/pull/6 -- thanks, Bernard!
kristaps
committed

Commits on Aug 22, 2016

Initial support for the official "-t" option, which allows the caller to
kristaps
committed
Have the pledge(2) sandbox accept an argument as to whether the challenge
kristaps
committed
Tweak documentation.
kristaps
committed

Commits on Aug 31, 2016

Add license (noted by florian@) and also note that letskencrypt is now
kristaps
committed
Typo noted by tj@. Thanks!
kristaps
committed

Commits on Sep 1, 2016

Commits on Sep 2, 2016

White-space fixes merged from downstream OpenBSD commits.
kristaps
committed
Continue merging white-space (and other misc.) fixes from downstream OpenBSD.
kristaps
committed
Ooops---add in lost comma.
kristaps
committed
Final raft of white-space changes from OpenBSD downstream.
kristaps
committed
Feature is now documented.
kristaps
committed

Commits on Sep 3, 2016

Commits on Oct 29, 2016

Fix https://github.com/kristapsdz/acme-client/pull/19 -- thanks!
kristaps
committed
Fix typos in https://github.com/kristapsdz/acme-client/pull/21 and https://github.com/kristapsdz/acme-client/pull/19 -- thanks!
kristaps
committed
Merge some churn from OpenBSD downstream.
kristaps
committed
Merge OpenBSD variable initialisation.
kristaps
committed
Merge some OpenBSD churn to reduce diff size.
kristaps
committed
Initialise the HTTP (really just the TLS) context so that it's not done each
kristaps
committed
Merge Openbsd changes for variables and rename "revoke" to revocate.
kristaps
committed
Merge more OpenBSD variable changes.
kristaps
committed
Bring more in line with OpenBSD's changes.
kristaps
committed
Compilation on older OpenBSD machines.
kristaps
committed

Commits on Oct 30, 2016

Commits on Oct 31, 2016

Commits on Nov 1, 2016

Allow expanding the SAN domains of a certificate.
kristaps
committed
If we have a new domain, force updating the certificate.
kristaps
committed

Commits on Nov 2, 2016

Use idiom suggested in OpenBSD's style(9).
kristaps
committed
Change __dead to be an __attribute__ (better portability).
kristaps
committed
Work around old versions of libtls.
kristaps
committed

Commits on Nov 9, 2016

Use timegm instead of mktime as we're processing a UTC time. Also, the
kristaps
committed

Commits on Nov 24, 2016

Add a fix for
kristaps
committed

Commits on Nov 25, 2016

Final check-in for fork+exec fallout: have an extra argument, '-X', that
kristaps
committed
Disallow '-X' in parent process.
kristaps
committed

Commits on Dec 2, 2016

Merge in OpenBSD's fix to the tls_close() function. And in doing so, back-
kristaps
committed

Commits on Dec 5, 2016

Force umask for creation of challenge file.
kristaps
committed

Commits on Jan 28, 2017

Commits on Jan 30, 2017

Move key-generation message prior to action so that long-running tasks can
kristaps
committed
Debug message before long-running action.
kristaps
committed

Commits on Feb 1, 2017

Reduce using "Let's Encrypt" unless where applicable. (Future versions will
kristaps
committed

Commits on Feb 12, 2017

Deprecate working with pre-5.9 OpenBSD. We should be using the most up to date
kristaps
committed

Commits on Feb 14, 2017

Be more clear.
kristaps
committed

Commits on Mar 12, 2017

Commits on Jul 1, 2017

Move example configuration into the EXAMPLE section and include both nginx
kristaps
committed

Commits on Jul 2, 2017

Add OpenBSD httpd(8) configuration.
kristaps
committed
Start moving operations (and configuration) into struct config.
kristaps
committed
Move "force" into configuration.
kristaps
committed
Move "expand" and "backup" into configuration object.
kristaps
committed
Move last "low-hanging fruit" config ops to configuration.
kristaps
committed
Bump copyright.
kristaps
committed
Move the choice of CA directory service into main.c and a config field.
kristaps
committed
Move agreement URL into configuration as well.
kristaps
committed
Move the challenge type into struct config.
kristaps
committed

Commits on Sep 9, 2018

Fix `<ctype.h>` arguments
Sebbyastian
authored