This repository was archived by the owner on Dec 1, 2018. It is now read-only.
Open
Conversation
added 30 commits
May 15, 2016 11:48
before the pledge just for consistency.
… that netproc failing doesn't cause short reads and exits.
…g but looks up addresses as used by netproc.
Prune a lot of unused variables.
kristapsdz/acme-client-portable#12 that pushes the check for file pre-existence with -n and -N only into the main process, stripping out the arguments before passing them to the child. This fixes a race condition.
allows certain variables to be overriden. This allows us to provide -nN and have them properly be nullified by the child processes.
…back- port that to the older API of libressl.
…ortable#13 . This creates a triplet exported to the operator: challenge type, domain, and print.
…s can be noted approriately. From kristapsdz#29 -- thanks!
…s will make this optional.)
…p to date version of libressl out there.
…versions as old as that.
…nginx and Apache (more to come). Inspired by kristapsdz#32 --- thanks!
You need to ensure the arguments passed to `<ctype.h>` functions are `unsigned char` values or `EOF`. Casting to `int` makes no difference here; that conversion would've been implicitly performed anyway due to the type of the function... what you need to do is cast to `unsigned char`. If you need to understand why this is the case, consider that the argument for character type functions might be used as an index for an array... and negative values would cause negative indexes, leading to a situation where attackers might be able to bleed sensitive parts of program context.
Author
|
While I'm on this function, a domain name is a list of labels, conventionally we separate those labels with periods... so the periods aren't really a part of the domain name per se. It's probably a bad idea to consider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You need to ensure the arguments passed to
<ctype.h>functions areunsigned charvalues orEOF. Casting tointmakes no difference here; that conversion would've been implicitly performed anyway due to the type of the argument... what you need to do is cast tounsigned char.If you need to understand why this is the case, consider that the argument for character type functions might be used as an index for an array... and negative values would cause negative indexes, leading to a situation where attackers might be able to bleed sensitive parts of program context.