Skip to content

HUB-11487: Fix layout of MenuItem component by adjusting flex properties #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2025
Merged

HUB-11487: Fix layout of MenuItem component by adjusting flex properties #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9597306
HUB-11487: Fix layout of MenuItem component by adjusting flex properties
ahmed-ramzi Oct 31, 2025
b8d1f92
HUB-11487: Fix styles
ahmed-ramzi Nov 3, 2025
a66d70e
Merge branch 'master' into bug/HUB-11487-Fix-menu-item-height
ahmed-ramzi Nov 4, 2025
8359b4d
Merge branch 'master' into bug/HUB-11487-Fix-menu-item-height
ahmed-ramzi Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cruel-pianos-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@knime/components": patch
---

Fix layout of MenuItem component by adjusting flex properties
4 changes: 2 additions & 2 deletions packages/components/src/components/base/MenuItem/BaseMenuItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,14 @@ const dynamicAttributes = (item: MenuItem) => {
& .label {
display: flex;
flex-direction: column;
align-content: flex-start;
place-content: flex-start center;
width: 100%;

& .text-and-hotkey {
display: flex;
align-items: center;
width: 100%;
height: 100%;
height: calc(var(--icon-size) * 1px);
text-align: left;

& .checkbox {
Expand Down