HUB-11487: Fix layout of MenuItem component by adjusting flex properties #76
Conversation
HUB-11487 (Fix menu item height)
🦋 Changeset detectedLatest commit: 8359b4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the layout and height behavior of the MenuItem component to prevent it from appearing too compact in the application. The changes adjust flexbox properties to ensure proper vertical alignment and height calculation based on icon size.
Key Changes:
- Modified flex alignment properties for better vertical centering
- Changed height calculation to be based on icon size rather than stretching to 100%
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/components/src/components/base/MenuItem/BaseMenuItem.vue | Updated flex properties and height calculation for MenuItem label and text container |
| .changeset/cruel-pianos-eat.md | Added changeset documenting the patch-level fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/components/src/components/base/MenuItem/BaseMenuItem.vue
Outdated
Show resolved
Hide resolved
HUB-11487 (Fix menu item height)
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HUB-11487 (Fix menu item height)
Should fix the layout on AP to not make it compact
This fix should revert the hight style to the previous change and remove the height 100%