Skip to content

fix(kncloudevents): truncate error body before base64 encode #9507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarkdotdev wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −7
Open

fix(kncloudevents): truncate error body before base64 encode #9507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions pkg/kncloudevents/event_dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,16 +583,33 @@ func dispatchExecutionInfoTransformers(destination *apis.URL, dispatchExecutionI

destination = sanitizeURL(destination)

// Encodes response body as base64 for the resulting length.
bodyLen := len(httpResponseBody)
encodedLen := base64.StdEncoding.EncodedLen(bodyLen)
if encodedLen > attributes.KnativeErrorDataExtensionMaxLength {
encodedLen = attributes.KnativeErrorDataExtensionMaxLength
}
// Encodes response body as base64, truncated so the encoded form fits in the
// knativeerrordata extension (KnativeErrorDataExtensionMaxLength characters).
maxEncodedLen := attributes.KnativeErrorDataExtensionMaxLength
maxRawLen := maxRawLenForBase64(maxEncodedLen)
if len(httpResponseBody) > maxRawLen {
httpResponseBody = httpResponseBody[:maxRawLen]
}
encodedLen := base64.StdEncoding.EncodedLen(len(httpResponseBody))
encodedBuf := make([]byte, encodedLen)
base64.StdEncoding.Encode(encodedBuf, httpResponseBody)

return attributes.KnativeErrorTransformers(*destination.URL(), dispatchExecutionInfo.ResponseCode, string(encodedBuf[:encodedLen]))
return attributes.KnativeErrorTransformers(*destination.URL(), dispatchExecutionInfo.ResponseCode, string(encodedBuf))
}

// maxRawLenForBase64 returns the largest source length whose standard base64 encoding
// uses at most maxEncodedLen bytes.
func maxRawLenForBase64(maxEncodedLen int) int {
if maxEncodedLen <= 0 {
return 0
}
// EncodedLen(n) = 4 * ((n + 2) / 3)
for n := (maxEncodedLen / 4) * 3; n >= 0; n-- {
if base64.StdEncoding.EncodedLen(n) <= maxEncodedLen {
return n
}
}
return 0
}

// isFailure returns true if the status code is not a successful HTTP status.
Expand Down