Skip to content

fix(kncloudevents): truncate error body before base64 encode - #9507

Open
amarkdotdev wants to merge 1 commit into
knative:mainfrom
amarkdotdev:fix/9504-dispatcher-large-error-body
Open

amarkdotdev wants to merge 1 commit into
knative:mainfrom
amarkdotdev:fix/9504-dispatcher-large-error-body

Conversation

@amarkdotdev

Copy link
Copy Markdown

Summary

Truncate the HTTP error response body before base64 encoding so knativeerrordata stays within the extension limit and the dispatcher no longer panics on large failure bodies (dead letter / reply paths).

Fixes #9504

Test plan

  • go test ./pkg/kncloudevents/... -run TestSendEvent

Avoid panic when failed delivery returns a large HTTP body and the
knativeerrordata extension is populated for dead letter sinks.

Fixes knative#9504

Signed-off-by: Aaron <amark@g.jct.ac.il>
@knative-prow
knative-prow Bot requested review from Leo6Leo and aliok November 3, 2026 19:16
@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amarkdotdev
Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

Welcome @amarkdotdev! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2026
@amarkdotdev

Copy link
Copy Markdown
Author

Fixes #9504. Happy to iterate if you want a different truncation strategy.

@knative-prow

knative-prow Bot commented Nov 3, 2026

Copy link
Copy Markdown

Hi @amarkdotdev. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dispatcher panics when a failed delivery returns a response body larger than 768 bytes

1 participant