Repository navigation
fix(kncloudevents): truncate error body before base64 encode - #9507
amarkdotdev wants to merge 1 commit into
Conversation
Avoid panic when failed delivery returns a large HTTP body and the knativeerrordata extension is populated for dead letter sinks. Fixes knative#9504 Signed-off-by: Aaron <amark@g.jct.ac.il>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amarkdotdev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @amarkdotdev! It looks like this is your first PR to knative/eventing 🎉 |
|
Fixes #9504. Happy to iterate if you want a different truncation strategy. |
|
Hi @amarkdotdev. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Truncate the HTTP error response body before base64 encoding so
knativeerrordatastays within the extension limit and the dispatcher no longer panics on large failure bodies (dead letter / reply paths).Fixes #9504
Test plan
go test ./pkg/kncloudevents/... -run TestSendEvent