Keep wasm download feedback active through module initialization - #114
Open
MUFFANUJ wants to merge 1 commit into
Open
Keep wasm download feedback active through module initialization#114MUFFANUJ wants to merge 1 commit into
MUFFANUJ wants to merge 1 commit into
Conversation
Member
|
Thanks for looking into this, but I don't think this is something I want to proceed with. I have come to the conclusion that I don't like my original idea of reporting the download within the terminal itself, it is too invasive and differs too much from that which occurs in a real terminal. I am leading towards removing the download tracker from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46 by wrapping Cockle’s wasm download callback in the terminal worker so the visual feedback stops only after the loaded Emscripten module factory resolves, covering the actual wasm fetch and initialization phase while preserving existing behavior for non-wasm modules.