Skip to content

Keep wasm download feedback active through module initialization - #114

Open
MUFFANUJ wants to merge 1 commit into
jupyterlite:mainfrom
MUFFANUJ:wasmFeedback
Open

Keep wasm download feedback active through module initialization#114
MUFFANUJ wants to merge 1 commit into
jupyterlite:mainfrom
MUFFANUJ:wasmFeedback

Conversation

@MUFFANUJ

@MUFFANUJ MUFFANUJ commented Jun 7, 2026

Copy link
Copy Markdown

Fixes #46 by wrapping Cockle’s wasm download callback in the terminal worker so the visual feedback stops only after the loaded Emscripten module factory resolves, covering the actual wasm fetch and initialization phase while preserving existing behavior for non-wasm modules.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

@ianthomas23

Copy link
Copy Markdown
Member

Thanks for looking into this, but I don't think this is something I want to proceed with.

I have come to the conclusion that I don't like my original idea of reporting the download within the terminal itself, it is too invasive and differs too much from that which occurs in a real terminal. I am leading towards removing the download tracker from cockle and instead replacing it with a more generic system of a Signal emitted when a command downloads, starts running and completes, which clients can choose to connect to if they wish. This covers other use cases as well as the download feedback. As to how this might surface in the terminal UI I am not sure yet; probably some text in the status bar which is similar to that displayed by kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VIsual feedback when downloading wasm module does not work

2 participants