Skip to content

fix: updated usage of Uncontrollable to fix issues in react 19 #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mahn00b wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: updated usage of Uncontrollable to fix issues in react 19 #2738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/Calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import clsx from 'clsx'
import PropTypes from 'prop-types'
import React from 'react'
import { uncontrollable } from 'uncontrollable'
import { useUncontrolled } from 'uncontrollable'
import {
accessor,
views as componentViews,
Expand Down Expand Up @@ -1180,8 +1180,28 @@ class Calendar extends React.Component {
}
}

export default uncontrollable(Calendar, {
view: 'onView',
date: 'onNavigate',
selected: 'onSelectEvent',
})
function UncontrolledCalendar(props) {
const controlledProps = useUncontrolled(props, {
view: 'onView',
date: 'onNavigate',
selected: 'onSelectEvent',
})

return <Calendar {...controlledProps} />
}

UncontrolledCalendar.propTypes = {
...Calendar.propTypes,
view: PropTypes.oneOfType([PropTypes.string, PropTypes.array]),
date: PropTypes.instanceOf(Date),
selected: PropTypes.object,
}

UncontrolledCalendar.defaultProps = {
...Calendar.defaultProps,
view: views.MONTH,
date: new Date(),
selected: null,
}

export default UncontrolledCalendar